Skip to content

Fix test Admin_Bar_Menu_Test::test_register_hooks after WordPress core change#22695

Merged
enricobattocchi merged 2 commits intorelease/26.4from
22693-fix-wp-tests-with-wp-trunk
Nov 6, 2025
Merged

Fix test Admin_Bar_Menu_Test::test_register_hooks after WordPress core change#22695
enricobattocchi merged 2 commits intorelease/26.4from
22693-fix-wp-tests-with-wp-trunk

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Nov 6, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes tests after a recent change to WordPress.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #22693

@vraja-pro vraja-pro added this to the 26.4 milestone Nov 6, 2025
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 6, 2025
@vraja-pro vraja-pro linked an issue Nov 6, 2025 that may be closed by this pull request
@vraja-pro vraja-pro changed the title Fix tests Fix test Admin_Bar_Menu_Test::test_register_hooks after WordPress core change Nov 6, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 6, 2025

Pull Request Test Coverage Report for Build 5221d3d6f1f572fc163dcd66cf554049104c2114

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 22693-fix-wp-tests-with-wp-trunk at 49.527%

Totals Coverage Status
Change from base Build ad171a0c8cb53da1c598f9c01cfad51faed614d2: 49.5%
Covered Lines: 17493
Relevant Lines: 35320

💛 - Coveralls

Comment thread tests/WP/Inc/Admin_Bar_Menu_Test.php Outdated
Co-authored-by: Enrico Battocchi <enrico@yoast.com>
@enricobattocchi enricobattocchi self-requested a review November 6, 2025 11:13
@enricobattocchi enricobattocchi merged commit 5172f0a into release/26.4 Nov 6, 2025
26 checks passed
@enricobattocchi enricobattocchi deleted the 22693-fix-wp-tests-with-wp-trunk branch November 6, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix WP tests with WP trunk

3 participants