Keep table background within rounded corners#22709
Merged
Conversation
Pull Request Test Coverage Report for Build b7e7f6877f9f2b1d4960eff9236df4a7f51552b7Details
💛 - Coveralls |
The thead/tbody backgrounds didnt take the table border radius into account. By applying the background color to the table cells instead, the border corners are now fully visible again. This can be seen in the RSS advanced settings of the plugin, the Semrush related keyphrase table, and the Storybook of the UI library itself. Its also noticeable in Shopify, MyYoast, and other consuming products.
Introduced additional story to show the striped row styling.
9ae1092 to
2a5bb6d
Compare
Contributor
|
CR & AC ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The thead/tbody backgrounds didnt take the table border radius into account. By applying the background color to the table cells instead, the border corners are now fully visible again.
This can be seen in the RSS advanced settings of the plugin, the Semrush related keyphrase table, and the Storybook of the UI library itself. Its also noticeable in Shopify, MyYoast, and other consuming products.
Summary
This PR can be summarized in the following changelog entry:
Table.Headbackground color styling to the header cell instead of the row. #22709Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
Quality assurance
Innovation
innovationlabel.Fixes personal annoyances.