Skip to content

Keep table background within rounded corners#22709

Merged
vraja-pro merged 4 commits intotrunkfrom
d-claassen/ui-library-table-corners
Nov 17, 2025
Merged

Keep table background within rounded corners#22709
vraja-pro merged 4 commits intotrunkfrom
d-claassen/ui-library-table-corners

Conversation

@d-claassen
Copy link
Copy Markdown
Contributor

@d-claassen d-claassen commented Nov 10, 2025

Context

The thead/tbody backgrounds didnt take the table border radius into account. By applying the background color to the table cells instead, the border corners are now fully visible again.

This can be seen in the RSS advanced settings of the plugin, the Semrush related keyphrase table, and the Storybook of the UI library itself. Its also noticeable in Shopify, MyYoast, and other consuming products.

afbeelding

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where table backgrounds in the RSS settings and Semrush related keyphrases tables would expand beyond the rounded corners in Firefox.
  • [@yoast/ui-library 0.1.0 other] Applies Table.Head background color styling to the header cell instead of the row. #22709
  • [@yoast/ui-library 0.0.1 other] Applies striped table row styling on the cell, instead of the row. #22709

Relevant technical choices:

  • n/a

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Check the RSS settings table
  • Check the Semrush related keyphrases table
  • [DEVS] Check the UI library storybook

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes personal annoyances.

@d-claassen d-claassen requested a review from a team as a code owner November 10, 2025 15:03
@d-claassen d-claassen added changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog UI change PRs that result in a change in the UI labels Nov 10, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 10, 2025

Pull Request Test Coverage Report for Build b7e7f6877f9f2b1d4960eff9236df4a7f51552b7

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.339%

Totals Coverage Status
Change from base Build a27514f8e0b862c6290d808bd633e53641b366ef: 0.0%
Covered Lines: 32208
Relevant Lines: 60580

💛 - Coveralls

The thead/tbody backgrounds didnt take the table border radius into account. By applying the background color to the table cells instead, the border corners are now fully visible again.

This can be seen in the RSS advanced settings of the plugin, the Semrush related keyphrase table, and the Storybook of the UI library itself. Its also noticeable in Shopify, MyYoast, and other consuming products.
Introduced additional story to show the striped row styling.
@d-claassen d-claassen force-pushed the d-claassen/ui-library-table-corners branch from 9ae1092 to 2a5bb6d Compare November 14, 2025 13:12
@vraja-pro vraja-pro self-assigned this Nov 17, 2025
@vraja-pro
Copy link
Copy Markdown
Contributor

CR & AC ✅

@vraja-pro vraja-pro added this to the 26.5 milestone Nov 17, 2025
@vraja-pro vraja-pro merged commit 14a2240 into trunk Nov 17, 2025
23 checks passed
@vraja-pro vraja-pro deleted the d-claassen/ui-library-table-corners branch November 17, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog UI change PRs that result in a change in the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants