Skip to content

836 task list create the task component#22717

Merged
JorPV merged 12 commits intofeature/task-listfrom
836-task-list-create-the-task-component
Nov 18, 2025
Merged

836 task list create the task component#22717
JorPV merged 12 commits intofeature/task-listfrom
836-task-list-create-the-task-component

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Nov 14, 2025

Context

Important

Should be testd after Task list: create task modal component is merged.

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/ui-library 0.0.1] Adds the ai variant to the Badge component.
  • [@yoast/tailwindcss-preset 0.0.1] Adds the ai primary background gradient.
  • [@yoast/dashboard-frontend 0.0.1] Adds the TaskRow component.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

For devs:

  • Spin the dashboard storybook

  • Check the TaskRow component story and documentation is clear and according to the design.

  • Check priority changes accordingly.

  • Check duration changes accordingly.

  • Check badge changes accordingly.

  • Check title changes accordingly.

  • Check completed state.

  • Check loading state.

Impact check:

  • Check duration and priority in the task modal are unchanged.

For devs: Spin ui-library storybook:

  • Check badge has the ai variant.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes # https://github.com/Yoast/reserved-tasks/issues/836

@vraja-pro vraja-pro added this to the feature/task-list milestone Nov 14, 2025
@vraja-pro vraja-pro requested a review from a team as a code owner November 14, 2025 12:02
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 14, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 14, 2025

Pull Request Test Coverage Report for Build 1c95d8d742b6fd366a78cacd08092330626cbe23

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 16 (81.25%) changed or added relevant lines in 5 files are covered.
  • 89 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.1%) to 56.551%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/dashboard-frontend/src/task-list/components/task-row.js 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
packages/js/src/general/store/index.js 7 0.0%
packages/js/src/elementor/initializers/render-sidebar.js 9 0.0%
packages/js/src/elementor/initialize.js 13 0.0%
packages/js/src/general/app.js 13 0.0%
packages/js/src/general/initialize.js 19 0.0%
packages/js/src/elementor/initializers/introduction-editor-v2.js 28 0.0%
Totals Coverage Status
Change from base Build 874c0a7e1e6981aba2efb72e44a4926529b5b478: -0.1%
Covered Lines: 14759
Relevant Lines: 25370

💛 - Coveralls

@JorPV JorPV requested a review from Copilot November 17, 2025 13:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds AI-related UI components and styling to support the task list feature, including a new AI badge variant and the core TaskRow component for displaying tasks in a table format.

Key Changes

  • Adds AI badge variant with gradient styling to the UI library
  • Implements TaskRow component with duration, priority, badges, completion status, and loading states
  • Adds supporting components (TaskBadge, Priority, Duration) with loading state support

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/ui-library/src/elements/badge/style.css Adds AI badge styling with gradient background
packages/ui-library/src/elements/badge/stories.js Adds AI badge to variants story
packages/ui-library/src/elements/badge/index.js Adds AI variant to badge className mapping
packages/ui-library/src/elements/badge/docs/variants.md Documents AI badge variant usage
packages/tailwindcss-preset/index.js Adds AI primary gradient background utility
packages/dashboard-frontend/tests/task-list/task-row.test.js Adds comprehensive test coverage for TaskRow component
packages/dashboard-frontend/stories/task-list/task-row/task-row.stories.js Adds TaskRow component stories with various states
packages/dashboard-frontend/stories/task-list/task-row/documentation.md Documents TaskRow component features
packages/dashboard-frontend/src/task-list/components/task-row.js Implements TaskRow component with loading states
packages/dashboard-frontend/src/task-list/components/task-badge.js Implements badge display for different task types
packages/dashboard-frontend/src/task-list/components/priority.js Adds loading state support to Priority component
packages/dashboard-frontend/src/task-list/components/duration.js Adds loading state support to Duration component
packages/dashboard-frontend/src/icons/index.js Exports Ellipse icon
packages/dashboard-frontend/src/icons/Ellipse.js Adds Ellipse icon for incomplete tasks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/dashboard-frontend/stories/task-list/task-row/task-row.stories.js Outdated
Comment thread packages/dashboard-frontend/src/icons/Ellipse.js Outdated
@JorPV JorPV requested a review from Copilot November 17, 2025 13:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/tailwindcss-preset/index.js Outdated
Comment thread packages/dashboard-frontend/src/task-list/components/task-row.js
Comment thread packages/dashboard-frontend/stories/task-list/task-row/task-row.stories.js Outdated
/**
* The Duration component to display task duration.
*
* @param {number} minutes The duration in minutes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a safeguard default value [minutes=1]

Copy link
Copy Markdown
Contributor Author

@vraja-pro vraja-pro Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure since this is a required prop. I think it's better to keep it like that so we can easily detect errors when response structure is incorrect.

Comment thread packages/dashboard-frontend/stories/task-list/task-row/documentation.md Outdated
Copy link
Copy Markdown
Contributor

@JorPV JorPV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vraja-pro Looks good. Just tiny changes suggested.

BTW, looking at the design shouldn't the sub-tasks action be an optional prop in the task-row component? 🤔

vraja-pro and others added 2 commits November 18, 2025 09:53
…w.stories.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@vraja-pro
Copy link
Copy Markdown
Contributor Author

The subtasks are not included in this phase..

@JorPV
Copy link
Copy Markdown
Contributor

JorPV commented Nov 18, 2025

CR ✅ AT ✅

@JorPV JorPV merged commit f28d94e into feature/task-list Nov 18, 2025
19 checks passed
@JorPV JorPV deleted the 836-task-list-create-the-task-component branch November 18, 2025 11:52
@FAMarfuaty FAMarfuaty added the innovation Innovative issue. Relating to performance, memory or data-flow. label Nov 18, 2025
@leonidasmi leonidasmi mentioned this pull request Nov 27, 2025
18 tasks
@leonidasmi leonidasmi removed this from the feature/task-list milestone Dec 1, 2025
@leonidasmi leonidasmi added this to the 26.6 milestone Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants