836 task list create the task component#22717
Conversation
Pull Request Test Coverage Report for Build 1c95d8d742b6fd366a78cacd08092330626cbe23Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull Request Overview
This PR adds AI-related UI components and styling to support the task list feature, including a new AI badge variant and the core TaskRow component for displaying tasks in a table format.
Key Changes
- Adds AI badge variant with gradient styling to the UI library
- Implements TaskRow component with duration, priority, badges, completion status, and loading states
- Adds supporting components (TaskBadge, Priority, Duration) with loading state support
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-library/src/elements/badge/style.css | Adds AI badge styling with gradient background |
| packages/ui-library/src/elements/badge/stories.js | Adds AI badge to variants story |
| packages/ui-library/src/elements/badge/index.js | Adds AI variant to badge className mapping |
| packages/ui-library/src/elements/badge/docs/variants.md | Documents AI badge variant usage |
| packages/tailwindcss-preset/index.js | Adds AI primary gradient background utility |
| packages/dashboard-frontend/tests/task-list/task-row.test.js | Adds comprehensive test coverage for TaskRow component |
| packages/dashboard-frontend/stories/task-list/task-row/task-row.stories.js | Adds TaskRow component stories with various states |
| packages/dashboard-frontend/stories/task-list/task-row/documentation.md | Documents TaskRow component features |
| packages/dashboard-frontend/src/task-list/components/task-row.js | Implements TaskRow component with loading states |
| packages/dashboard-frontend/src/task-list/components/task-badge.js | Implements badge display for different task types |
| packages/dashboard-frontend/src/task-list/components/priority.js | Adds loading state support to Priority component |
| packages/dashboard-frontend/src/task-list/components/duration.js | Adds loading state support to Duration component |
| packages/dashboard-frontend/src/icons/index.js | Exports Ellipse icon |
| packages/dashboard-frontend/src/icons/Ellipse.js | Adds Ellipse icon for incomplete tasks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /** | ||
| * The Duration component to display task duration. | ||
| * | ||
| * @param {number} minutes The duration in minutes. |
There was a problem hiding this comment.
Maybe add a safeguard default value [minutes=1]
There was a problem hiding this comment.
I'm not sure since this is a required prop. I think it's better to keep it like that so we can easily detect errors when response structure is incorrect.
There was a problem hiding this comment.
@vraja-pro Looks good. Just tiny changes suggested.
BTW, looking at the design shouldn't the sub-tasks action be an optional prop in the task-row component? 🤔
…w.stories.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
The subtasks are not included in this phase.. |
|
CR ✅ AT ✅ |
Context
Important
Should be testd after Task list: create task modal component is merged.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
For devs:
Spin the dashboard storybook
Check the TaskRow component story and documentation is clear and according to the design.
Check priority changes accordingly.
Check duration changes accordingly.
Check badge changes accordingly.
Check title changes accordingly.
Check completed state.
Check loading state.
Impact check:
For devs: Spin ui-library storybook:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes # https://github.com/Yoast/reserved-tasks/issues/836