Create tasks based on post types by leonidasmi · Pull Request #22718 · Yoast/wordpress-seo

leonidasmi · 2025-11-17T09:16:30Z

Context

This task is about creating tasks for the search appearance templates of the page/post/product post types.

Summary

This PR can be summarized in the following changelog entry:

Creates tasks based on post types.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Running the GET request (http://example.com/wp-json/yoast/v1/get_tasks) now also includes the following tasks too:

        "set-search-appearance-templates-post": {
            "id": "set-search-appearance-templates-post",
            "duration": 10,
            "priority": "high",
            "is_completed": false,
            "call_to_action": {
                "label": "Customize search appearance",
                "type": "link",
                "href": "http://dev.local/wp-admin/admin.php?page=wpseo_page_settings#/post-type/posts"
            },
            "copy_set": {
                "title": "Set search appearance templates for your posts",
                "why": "Custom search appearance templates help improve how your content looks in search results, driving more clicks.",
                "how": "Customize search appearance templates for your posts."
            }
        },
        "set-search-appearance-templates-page": {
            "id": "set-search-appearance-templates-page",
            "duration": 10,
            "priority": "high",
            "is_completed": false,
            "call_to_action": {
                "label": "Customize search appearance",
                "type": "link",
                "href": "http://dev.local/wp-admin/admin.php?page=wpseo_page_settings#/post-type/pages"
            },
            "copy_set": {
                "title": "Set search appearance templates for your pages",
                "why": "Custom search appearance templates help improve how your content looks in search results, driving more clicks.",
                "how": "Customize search appearance templates for your pages."
            }
        },
        "set-search-appearance-templates-product": {
            "id": "set-search-appearance-templates-product",
            "duration": 10,
            "priority": "high",
            "is_completed": false,
            "call_to_action": {
                "label": "Customize search appearance",
                "type": "link",
                "href": "http://dev.local/wp-admin/admin.php?page=wpseo_page_settings#/post-type/product"
            },
            "copy_set": {
                "title": "Set search appearance templates for your products",
                "why": "Custom search appearance templates help improve how your content looks in search results, driving more clicks.",
                "how": "Customize search appearance templates for your products."
            }
        }

the product one is included only when Woo is active
the logic behind the is_completed is:
- if either one of the SEO title or meta description template for that post type is changed from the default value, it's true.
- if none of the SEO title or meta description template for that post type is changed from the default value, it's false.
Check the href values and confirm that you are pointed to the settings of the respective post type
- Smoke test the settings of taxonomies, because we did a small change to the routes of those too. Just go to Yoast settings->Categories & tags->Categories and save a couple of settings to confirm everything looks good.

Relevant test scenarios

Changes should be tested with the browser console open
Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
Changes should be tested on different browsers
Changes should be tested on multisite

Test instructions for QA when the code is in the RC

QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

I have tested this code to the best of my abilities.
During testing, I had activated all plugins that Yoast SEO provides integrations for.
I have added unit tests to verify the code works as intended.
If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
I have written this PR in accordance with my team's definition of done.
I have checked that the base branch is correctly set.

Innovation

No innovation project is applicable for this PR.
This PR falls under an innovation project. I have attached the innovation label.
I have added my hours to the WBSO document.

Fixes #

…create-all-dynamic-tasks

…tasks

coveralls · 2025-11-17T20:36:42Z

Pull Request Test Coverage Report for Build e38babf55c2d6bc027a1405c8548cf4cac30b000

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

3 of 71 (4.23%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on 838-backend-create-all-dynamic-tasks at 52.166%

Changes Missing Coverage	Changed/Added Lines	%
src/task-list/application/tasks-collector.php	2	0.0%
src/helpers/route-helper.php	9	0.0%
src/task-list/domain/tasks/abstract-post-type-task.php	10	0.0%
src/task-list/infrastructure/register-post-type-tasks-integration.php	17	0.0%
src/task-list/application/tasks/set-search-appearance-templates.php	30	0.0%

Totals
Change from base Build 55a8e7b462a870be13d15b732f896e4c55c315a6:	52.2%
Covered Lines:	30982
Relevant Lines:	59572

💛 - Coveralls

thijsoo

Some suggestions.

thijsoo · 2025-11-18T13:24:22Z

+/**
+ * Represents the task for setting search appearance templates.
+ */
+class Set_Search_Appearance_Templates extends Abstract_Post_Type_Task {


I am thinking that it might make sense to have these in the infrastructure folder since they are super tightly coupled with WP 🤔

That was a conscious decision actually, as I would like us to have all tasks gathered in a single layer and not scattered throughout multiple ones.

thijsoo · 2025-11-18T13:28:07Z

+	 * @return Post_Type_Task_Interface
+	 */
+	public function duplicate_for_post_type( string $post_type ): Post_Type_Task_Interface {
+		$clone = clone $this;


I might be misremembering clone but I thought this copied memory pointers so when you do this and set ->duration on one object does this also change it in the other or is that fine 🤔

But I clone and then I do $clone->set_post_type( $post_type );, but my end results are what I expected 🤔

Not sure if/how I could improve this? I'd be happy to implement a different approach

Co-authored-by: Thijs van der Heijden <thijsoo@users.noreply.github.com>

thijsoo

CR + ACC 👍

leonidasmi added 2 commits November 14, 2025 09:48

Merge branch '839-backend-create-all-premium-tasks' into 838-backend-…

95c2ef8

…create-all-dynamic-tasks

Add tasks based on post types

3a27d6a

leonidasmi changed the base branch from trunk to feature/task-list November 17, 2025 09:16

leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 17, 2025

leonidasmi added this to the feature/task-list milestone Nov 17, 2025

leonidasmi added 2 commits November 17, 2025 11:59

Don't add dynamic property when registering post type tasks

618ae0b

Add detection method of complete state

c052dff

leonidasmi force-pushed the 838-backend-create-all-dynamic-tasks branch from 04255c3 to c052dff Compare November 17, 2025 10:47

leonidasmi added 2 commits November 17, 2025 12:49

Merge branch 'feature/task-list' into 838-backend-create-all-dynamic-…

9e3428c

…tasks

Add a way for Premium to register its own post type tasks

fa9ab4f

Clean up

7f55d0a

leonidasmi marked this pull request as ready for review November 18, 2025 10:17

thijsoo requested changes Nov 18, 2025

View reviewed changes

leonidasmi and others added 3 commits November 18, 2025 15:40

Update src/integrations/settings-integration.php

822143d

Co-authored-by: Thijs van der Heijden <thijsoo@users.noreply.github.com>

Add comment explaining the post type tasks

28f26c5

Add todo about validating the new hook

53ca7e6

thijsoo approved these changes Nov 19, 2025

View reviewed changes

thijsoo merged commit cf9a5eb into feature/task-list Nov 19, 2025
31 of 37 checks passed

thijsoo deleted the 838-backend-create-all-dynamic-tasks branch November 19, 2025 11:04

leonidasmi mentioned this pull request Nov 27, 2025

Feature/task list #22759

Merged

18 tasks

leonidasmi modified the milestones: feature/task-list, 26.6 Dec 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create tasks based on post types#22718

Create tasks based on post types#22718
thijsoo merged 10 commits intofeature/task-listfrom
838-backend-create-all-dynamic-tasks

leonidasmi commented Nov 17, 2025 •

edited

Loading

Uh oh!

coveralls commented Nov 17, 2025 •

edited

Loading

Uh oh!

thijsoo left a comment

Uh oh!

Uh oh!

Uh oh!

thijsoo Nov 18, 2025

Uh oh!

leonidasmi Nov 18, 2025

Uh oh!

thijsoo Nov 18, 2025

Uh oh!

leonidasmi Nov 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

thijsoo left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

leonidasmi commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Summary

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

Relevant test scenarios

Test instructions for QA when the code is in the RC

Impact check

Other environments

Documentation

Quality assurance

Innovation

Uh oh!

coveralls commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build e38babf55c2d6bc027a1405c8548cf4cac30b000

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

thijsoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thijsoo Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

leonidasmi Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

thijsoo Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

leonidasmi Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thijsoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leonidasmi commented Nov 17, 2025 •

edited

Loading

coveralls commented Nov 17, 2025 •

edited

Loading

leonidasmi Nov 18, 2025 •

edited

Loading