Skip to content

22723 adds the accessibility addon to the dashboard frontend storybook#22725

Merged
vraja-pro merged 1 commit intofeature/task-listfrom
22723-adds-the-accessibility-addon-to-the-dashboard-frontend-storybook
Nov 20, 2025
Merged

22723 adds the accessibility addon to the dashboard frontend storybook#22725
vraja-pro merged 1 commit intofeature/task-listfrom
22723-adds-the-accessibility-addon-to-the-dashboard-frontend-storybook

Conversation

@JorPV
Copy link
Copy Markdown
Contributor

@JorPV JorPV commented Nov 18, 2025

Context

  • Add the accessibility addon

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/dashboard-frontend 0.0.1] Adds the accessibility add-on to Storybook.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to the package directory in your terminal.
  • Run the storybook locally with the command yarn workspace @yoast/dashboard-frontend storybook
  • Check the accessibility tab is present in the single stories.
image

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #22723

@JorPV JorPV linked an issue Nov 18, 2025 that may be closed by this pull request
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 18902b098fa5d94faa52f2ea03edd8e44898aab8

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.533%

Totals Coverage Status
Change from base Build 150b3380ee314c8d0ddd98b1563408e677519117: 0.0%
Covered Lines: 14747
Relevant Lines: 25356

💛 - Coveralls

@JorPV JorPV force-pushed the 22723-adds-the-accessibility-addon-to-the-dashboard-frontend-storybook branch from f4e9ee3 to 275bd23 Compare November 18, 2025 09:29
@JorPV JorPV added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 18, 2025
@JorPV JorPV marked this pull request as ready for review November 18, 2025 09:35
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅

@vraja-pro vraja-pro added this to the feature/task-list milestone Nov 20, 2025
@vraja-pro vraja-pro merged commit 73a658d into feature/task-list Nov 20, 2025
32 of 36 checks passed
@vraja-pro vraja-pro deleted the 22723-adds-the-accessibility-addon-to-the-dashboard-frontend-storybook branch November 20, 2025 12:06
@leonidasmi leonidasmi mentioned this pull request Nov 27, 2025
18 tasks
@leonidasmi leonidasmi modified the milestones: feature/task-list, 26.6 Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adds the accessibility addon to the dashboard-frontend storybook

4 participants