Skip to content

843 task list implement tasks progress bar and adds upsell row#22735

Merged
FAMarfuaty merged 18 commits intofeature/task-listfrom
843-task-list-implement-tasks-and-store-from-dashboard-frontend
Nov 21, 2025
Merged

843 task list implement tasks progress bar and adds upsell row#22735
FAMarfuaty merged 18 commits intofeature/task-listfrom
843-task-list-implement-tasks-and-store-from-dashboard-frontend

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Nov 20, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Implements the tasks progress bar and adds the upsell row to the tasks list.
  • [@yoast/dashboard-frontend 0.1.0] Adds children prop to the task row and selectors to the task list redux slice.
  • [@yoast/dashboard-frontend 0.0.1] Adds JS docs to the initial state of the task list redux slice.
  • [@yoast/dashboard-frontend 0.0.1] Fixes the RTL direction of the task row chevron.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to General -> Task list
  • Check you see the progress bar above the tasks table
  • Check the Table has an upsell row with the link https://yoa.st/task-list-upsell-table-footer
  • Check the link is with query args (link params)
  • Check the progress bar and upsell link match the designs.
  • Enable premium
  • Check the tasks from premium has a premium badge. No longer relevant

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have ran grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/843

+ fix export of task list components
…t-implement-tasks-and-store-from-dashboard-frontend
…-list-implement-tasks-and-store-from-dashboard-frontend
@vraja-pro vraja-pro added this to the feature/task-list milestone Nov 20, 2025
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 20, 2025
@vraja-pro vraja-pro changed the title 843 task list implement tasks and store from dashboard frontend 843 task list implement tasks progress bar and adds upsell row Nov 20, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 20, 2025

Pull Request Test Coverage Report for Build ed1683d813800ea591b7a043913d226805fbb43a

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 38 (21.05%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 53.157%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/general/initialize.js 0 1 0.0%
packages/js/src/general/components/task-list-upsell-row.js 1 3 33.33%
packages/js/src/general/components/task.js 1 6 16.67%
packages/js/src/general/routes/task-list.js 0 8 0.0%
packages/dashboard-frontend/src/store/task-list.js 5 19 26.32%
Files with Coverage Reduction New Missed Lines %
packages/js/src/general/routes/task-list.js 1 2.94%
packages/js/src/general/initialize.js 1 0.0%
Totals Coverage Status
Change from base Build 7af5ceb0b9d63446ab2014f40579c51487b8407e: 0.5%
Covered Lines: 32382
Relevant Lines: 61226

💛 - Coveralls

Comment thread packages/js/src/general/components/task.js Outdated
@FAMarfuaty
Copy link
Copy Markdown
Contributor

Clicking on the upsell button, the URL is opened on the same window instead of on a new tab. Is this expected?

Comment thread packages/js/src/general/initialize.js
@FAMarfuaty
Copy link
Copy Markdown
Contributor

CR & AT ✅
LGTM ✨

@FAMarfuaty FAMarfuaty added the innovation Innovative issue. Relating to performance, memory or data-flow. label Nov 21, 2025
@FAMarfuaty FAMarfuaty merged commit 532baab into feature/task-list Nov 21, 2025
23 checks passed
@FAMarfuaty FAMarfuaty deleted the 843-task-list-implement-tasks-and-store-from-dashboard-frontend branch November 21, 2025 13:44
@leonidasmi leonidasmi mentioned this pull request Nov 27, 2025
18 tasks
@leonidasmi leonidasmi modified the milestones: feature/task-list, 26.6 Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants