Skip to content

Add task about new content#22745

Merged
FAMarfuaty merged 5 commits intofeature/task-listfrom
854-backend-add-task-for-new-content
Nov 26, 2025
Merged

Add task about new content#22745
FAMarfuaty merged 5 commits intofeature/task-listfrom
854-backend-add-task-for-new-content

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi commented Nov 24, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds task about new content.

Relevant technical choices:

  • Changed the frontend logic for the CTA button and made the add types into links as well.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Have no posts published the last 30 days
  • Go to the task list and confirm that you see a Create new content task as incomplete
  • Open the task and confirm it looks like this:
image
  • Click the button and confirm that it points you to the new post page
  • Have a post published the last 30 days
  • Go to the task list and confirm that the Create new content task as now complete
  • Delete that published post and again have no posts published the last 30 days
  • Add the following snippet that makes posts non-public as a post type:
add_action( 'init', 'make_posts_non_public', 999 );
function make_posts_non_public() {
    global $wp_post_types;

    if ( isset( $wp_post_types['post'] ) ) {
        $wp_post_types['post']->public = false;
        $wp_post_types['post']->publicly_queryable = false;
        $wp_post_types['post']->show_ui = true; // Keep admin UI
        $wp_post_types['post']->show_in_menu = true; // Keep in admin menu
    }
}
  • Go to the task list and confirm that the Create new content task as now complete

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have ran grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@leonidasmi leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 24, 2025
@leonidasmi leonidasmi added this to the feature/task-list milestone Nov 24, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 24, 2025

Pull Request Test Coverage Report for Build 19d79220a338ff9b308b81bd69a6b3ea92114a3e

Details

  • 2 of 34 (5.88%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 53.144%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/task-list/application/tasks/create-new-content.php 0 32 0.0%
Totals Coverage Status
Change from base Build e61fbb6c954c740de0e70987dc7b175c48d7a491: -0.02%
Covered Lines: 32389
Relevant Lines: 61279

💛 - Coveralls

@leonidasmi leonidasmi marked this pull request as ready for review November 24, 2025 12:59
Copy link
Copy Markdown
Member

@enricobattocchi enricobattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me!

@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

@FAMarfuaty FAMarfuaty added the innovation Innovative issue. Relating to performance, memory or data-flow. label Nov 26, 2025
Copy link
Copy Markdown
Contributor

@FAMarfuaty FAMarfuaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AT ✅
Code looks neat and it works as expected ✨

@FAMarfuaty FAMarfuaty merged commit c88d287 into feature/task-list Nov 26, 2025
39 checks passed
@FAMarfuaty FAMarfuaty deleted the 854-backend-add-task-for-new-content branch November 26, 2025 10:35
@leonidasmi leonidasmi mentioned this pull request Nov 27, 2025
18 tasks
@leonidasmi leonidasmi modified the milestones: feature/task-list, 26.6 Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants