870 tasks list hover states and completed state styling

[vraja-pro]

Context

Summary

This PR can be summarized in the following changelog entry:

• [@yoast/dashboard-frontend 0.0.1] Updated style for task row states.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Check completed task row have the task name with slate 500 color.
• Check completed task has the duration and priority set to opacity 0.5.
• On row hover and focus:
  • Check background color changes to slate-50
  • Check chevron moves 8 pixel with transition.
  • Check task title has underline.
  • When navigating using tabs, check title doesn't have outline.
• Only QA: Use screen reader and navigate to the tasks, check screen reader recites "completed" or "incomplete".

DEVS:

• Spin dashboard-frontend storybook and repeat tests for Task row stories.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.
• I have ran grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes Task list: Fix task row completed task styling
https://github.com/Yoast/reserved-tasks/issues/870

[coveralls]

Pull Request Test Coverage Report for Build ea556cfc15b4b2ca3295841159597e818c1ad598

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.5%) to 53.171%

---

Totals
Change from base Build f25d8d99516e47a441deba0dccbae3df95436b6e:	0.5%
Covered Lines:	32391
Relevant Lines:	61249

---

💛 - Coveralls

[leonidasmi]

CR: 🏗️

And a couple of remarks while testing it a bit:

• When clicking the title of a completed task and then pressing ESC to close the modal, there is a border around the task's title, until the element loses its focus:

• There's a difference when opening a task by clicking its title and opening one by clicking anywhere else. In the first case, when pressing ESC to close the modal, the focus returns to the task and in the second case, the focus doesnt return to the task. Minor, but if it's easy to fix, lets.

[leonidasmi]

A quick remark, we say:

On row hover and focus -> Check task title has underline

but it doesn't, on focus. it has an underline only on hover

[leonidasmi]

I'm also gonna leave the accessibility acceptance to QA for now