Skip to content

Task list: adds screen reader text for the progress bar#22751

Merged
vraja-pro merged 5 commits intofeature/task-listfrom
879-nice-to-have-task-list-fix-tasks-progress-bar-accessibility
Nov 27, 2025
Merged

Task list: adds screen reader text for the progress bar#22751
vraja-pro merged 5 commits intofeature/task-listfrom
879-nice-to-have-task-list-fix-tasks-progress-bar-accessibility

Conversation

@FAMarfuaty
Copy link
Copy Markdown
Contributor

@FAMarfuaty FAMarfuaty commented Nov 25, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/dashboard-frontend 0.0.1] Adds screen reader text to the progress bar.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to the Task list
  • Activated the screen reader in your computer, e.g. VoiceOver
  • Navigate to the progress bar and focus on it
  • Confirm that the screen reader text is read aloud, e.g. "2 out of 5 tasks completed"
  • On hovering over the progress bar, the screen reader should not read aloud the text

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • N/A

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have ran grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/879

@FAMarfuaty FAMarfuaty added this to the feature/task-list milestone Nov 25, 2025
@FAMarfuaty FAMarfuaty added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow. labels Nov 25, 2025
@FAMarfuaty FAMarfuaty marked this pull request as ready for review November 25, 2025 16:07
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 25, 2025

Pull Request Test Coverage Report for Build e1be77beaffbcb3c5bf9ecf43004ff225a5fb41b

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 45 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.5%) to 53.106%

Files with Coverage Reduction New Missed Lines %
packages/js/src/general/store/index.js 6 0.0%
packages/js/src/settings/helpers/search.js 6 15.0%
packages/js/src/general/app.js 13 0.0%
packages/js/src/general/initialize.js 20 0.0%
Totals Coverage Status
Change from base Build a31c583ae9894144bd1302b094668a9a5aa45e34: 0.5%
Covered Lines: 32412
Relevant Lines: 61370

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

…to 879-nice-to-have-task-list-fix-tasks-progress-bar-accessibility
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅

@vraja-pro vraja-pro merged commit 2f15d9c into feature/task-list Nov 27, 2025
20 checks passed
@vraja-pro vraja-pro deleted the 879-nice-to-have-task-list-fix-tasks-progress-bar-accessibility branch November 27, 2025 15:36
@vraja-pro vraja-pro mentioned this pull request Nov 27, 2025
18 tasks
@leonidasmi leonidasmi modified the milestones: feature/task-list, 26.6 Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants