Remove badges from tasks#22752
Merged
vraja-pro merged 6 commits intofeature/task-listfrom Nov 27, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 12168a9461e78d78aa17d829e596a51fa33897c1Details
💛 - Coveralls |
vraja-pro
requested changes
Nov 26, 2025
Contributor
vraja-pro
left a comment
There was a problem hiding this comment.
I actually prefer to set the badge to null when setting the tasks in the store.
packages/dashboard-frontend/src/store/task-list.js line 83:
setTasks( state, { payload } ) {
keys( payload ).forEach( ( id ) => {
payload[ id ].status = ASYNC_ACTION_STATUS.idle;
payload[ id ].error = null;
payload[ id ].badge = null;
} );
state.tasks = payload;
},That way we keep the tests and the component functionality.
vraja-pro
approved these changes
Nov 27, 2025
Contributor
|
CR & AC ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
<Premium>badge.Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
grunt build:imagesand commited the results, if my PR introduces new images or SVGs.Innovation
innovationlabel.Fixes #