Skip to content

Remove badges from tasks#22752

Merged
vraja-pro merged 6 commits intofeature/task-listfrom
881-remove-premium-labels-from-tasks
Nov 27, 2025
Merged

Remove badges from tasks#22752
vraja-pro merged 6 commits intofeature/task-listfrom
881-remove-premium-labels-from-tasks

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi commented Nov 26, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Removes the Premium badges from the tasks.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Enable Premium and go to the task list
  • Confirm that no tasks have the <Premium> badge.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have ran grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@leonidasmi leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 26, 2025
@leonidasmi leonidasmi added this to the feature/task-list milestone Nov 26, 2025
@leonidasmi leonidasmi marked this pull request as ready for review November 26, 2025 11:16
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 26, 2025

Pull Request Test Coverage Report for Build 12168a9461e78d78aa17d829e596a51fa33897c1

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-7.3%) to 41.681%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/dashboard-frontend/src/store/task-list.js 0 1 0.0%
Totals Coverage Status
Change from base Build 7561f46cff3e6b924be9a525ca603c82678cf226: -7.3%
Covered Lines: 22722
Relevant Lines: 51167

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually prefer to set the badge to null when setting the tasks in the store.
packages/dashboard-frontend/src/store/task-list.js line 83:

setTasks( state, { payload } ) {
			keys( payload ).forEach( ( id ) => {
				payload[ id ].status = ASYNC_ACTION_STATUS.idle;
				payload[ id ].error = null;
                                 payload[ id ].badge = null;
			} );
			state.tasks = payload;
		},

That way we keep the tests and the component functionality.

@vraja-pro
Copy link
Copy Markdown
Contributor

vraja-pro commented Nov 27, 2025

CR & AC ✅

@vraja-pro vraja-pro merged commit b2920dc into feature/task-list Nov 27, 2025
18 of 19 checks passed
@vraja-pro vraja-pro deleted the 881-remove-premium-labels-from-tasks branch November 27, 2025 09:09
@leonidasmi leonidasmi mentioned this pull request Nov 27, 2025
18 tasks
@leonidasmi leonidasmi modified the milestones: feature/task-list, 26.6 Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants