Skip to content

Move completed tasks to the bottom of the list#22755

Merged
vraja-pro merged 5 commits intofeature/task-listfrom
869-task-list-move-completed-tasks-to-the-bottom-of-the-list
Nov 27, 2025
Merged

Move completed tasks to the bottom of the list#22755
vraja-pro merged 5 commits intofeature/task-listfrom
869-task-list-move-completed-tasks-to-the-bottom-of-the-list

Conversation

@FAMarfuaty
Copy link
Copy Markdown
Contributor

@FAMarfuaty FAMarfuaty commented Nov 26, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Moves the completed tasks to the bottom of the task list.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to Task list
  • Confirm that all completed tasks (if any) that you have are put at the bottom of the list
  • Make the llms.txt task incomplete if it was completed
  • Open the llms.txt task and click the Enable llms.txt button
  • Confirm that the llms.txt task is already moved to the bottom of the list as soon as the task is completed
  • Open a task with a link button, e.g. Create new content, and click the button inside the task modal
  • You'll be directed to the editor to create a new content
  • Create a new content
  • Go back to Task list and confirm that the "Create new content" task is put at the bottom among other completed tasks

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • N/A

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have ran grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/869

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 26, 2025

Pull Request Test Coverage Report for Build 4b608722ae862d5a0aa581be4d1a54aac1ac36fd

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 53.385%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/general/routes/task-list.js 0 4 0.0%
Totals Coverage Status
Change from base Build bd247f26a35052d669a0ea62eafb073750740386: -0.005%
Covered Lines: 32406
Relevant Lines: 60954

💛 - Coveralls

@FAMarfuaty FAMarfuaty added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 27, 2025
@FAMarfuaty FAMarfuaty added this to the feature/task-list milestone Nov 27, 2025
@FAMarfuaty FAMarfuaty marked this pull request as ready for review November 27, 2025 09:17
@FAMarfuaty FAMarfuaty added the innovation Innovative issue. Relating to performance, memory or data-flow. label Nov 27, 2025
@leonidasmi leonidasmi mentioned this pull request Nov 27, 2025
18 tasks
@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

…-list-move-completed-tasks-to-the-bottom-of-the-list
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅

@vraja-pro vraja-pro merged commit 5fc4bb2 into feature/task-list Nov 27, 2025
20 checks passed
@vraja-pro vraja-pro deleted the 869-task-list-move-completed-tasks-to-the-bottom-of-the-list branch November 27, 2025 13:38
@leonidasmi leonidasmi modified the milestones: feature/task-list, 26.6 Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants