Skip to content

875 nice to have task list first time configuration completed update#22765

Merged
leonidasmi merged 5 commits intofeature/task-listfrom
875-nice-to-have-task-list-first-time-configuration-completed-update
Nov 28, 2025
Merged

875 nice to have task list first time configuration completed update#22765
leonidasmi merged 5 commits intofeature/task-listfrom
875-nice-to-have-task-list-first-time-configuration-completed-update

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Nov 28, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Updated the first time configuration task in the task list without the need to refresh the page.
  • [@yoast/dashboard-frontend 0.0.1] Adds selector and action to the task list redux slice for the completed state of a task.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Have the FTC task to be incomplete, (can be reset with the Yoast helper (reset ftc, reset options))
  • Go to the task list and check the FTC task is incomplete.
  • Click on the task and check the modal contains only the "Why this matters" copy:
Screenshot 2025-11-28 at 11 34 23
  • Navigate to the FTC tab and complete the first time configuration.
  • Navigate back to the task list and check the FTC task is completed and in the bottom of the list.
  • Repeat the tests but this time have a clean site and first go to the FTC without visiting the task list first.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have ran grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes [nice-to-have]: Task list: first time configuration completed update

@vraja-pro vraja-pro added this to the feature/task-list milestone Nov 28, 2025
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 28, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 28, 2025

Pull Request Test Coverage Report for Build fbed9a4ec3f638eeb71df1369834c5763543c081

Details

  • 1 of 7 (14.29%) changed or added relevant lines in 2 files are covered.
  • 47 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.5%) to 53.099%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/dashboard-frontend/src/store/task-list.js 1 3 33.33%
packages/js/src/first-time-configuration/first-time-configuration-steps.js 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/first-time-configuration/first-time-configuration-steps.js 1 0.0%
src/task-list/application/tasks/complete-ftc.php 1 0.0%
packages/js/src/general/store/index.js 6 0.0%
packages/js/src/settings/helpers/search.js 6 15.0%
packages/js/src/general/app.js 13 0.0%
packages/js/src/general/initialize.js 20 0.0%
Totals Coverage Status
Change from base Build 0840e7bf144fa23e63f03b3d43ae80f5a35be142: 0.5%
Covered Lines: 32413
Relevant Lines: 61375

💛 - Coveralls

Comment thread packages/dashboard-frontend/src/store/task-list.js Outdated
@leonidasmi leonidasmi mentioned this pull request Nov 28, 2025
18 tasks
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + Acceptance test is ✅

@leonidasmi leonidasmi merged commit 4fef8df into feature/task-list Nov 28, 2025
37 checks passed
@leonidasmi leonidasmi deleted the 875-nice-to-have-task-list-first-time-configuration-completed-update branch November 28, 2025 13:36
@leonidasmi leonidasmi modified the milestones: feature/task-list, 26.6 Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants