Skip to content

Fix copy for disabled schema alert#22845

Merged
enricobattocchi merged 1 commit intotrunkfrom
936-improve-schema-output-disabled-copy
Jan 2, 2026
Merged

Fix copy for disabled schema alert#22845
enricobattocchi merged 1 commit intotrunkfrom
936-improve-schema-output-disabled-copy

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Dec 31, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Improves the message displayed when Schema output is disabled.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Apply this filter (either through snippets plugin or functions.php)
add_filter( 'wpseo_json_ld_output', '__return_false' );
  • Go to Yoast SEO -> Settings -> Advanced -> Schema
  • Check you see the following alert:
immagine

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/936

@vraja-pro vraja-pro added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog changelog: other Needs to be included in the 'Other' category in the changelog and removed changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Dec 31, 2025
@vraja-pro vraja-pro changed the title Fix copy Fix copy for disabled schema alert Dec 31, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7c374cd8bdb6ab3d22edb107c52912e4226821de

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.301%

Totals Coverage Status
Change from base Build c1c90b0c933a32668d5b53c2258a9215e16e224a: 0.0%
Covered Lines: 14949
Relevant Lines: 25865

💛 - Coveralls

@enricobattocchi enricobattocchi self-requested a review January 2, 2026 09:45
Copy link
Copy Markdown
Member

@enricobattocchi enricobattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AT ok

@enricobattocchi enricobattocchi added this to the 26.8 milestone Jan 2, 2026
@enricobattocchi enricobattocchi merged commit 6d5f0b5 into trunk Jan 2, 2026
27 checks passed
@enricobattocchi enricobattocchi deleted the 936-improve-schema-output-disabled-copy branch January 2, 2026 09:47
@leonidasmi leonidasmi added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog and removed changelog: other Needs to be included in the 'Other' category in the changelog labels Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants