GH Actions: fail "setup-php" if requested tooling could not be installed#22852
Merged
GH Actions: fail "setup-php" if requested tooling could not be installed#22852
Conversation
Setup-PHP will normally "gracefully" show a warning and not the build when an extension or tool failed to install. This is not particularly useful as that means that either there will be a failure later on in the build due to the extension or tool missing, or the build will not be representative of what is supposed to be tested. This commit changes this behaviour to fail the build at the `setup-php` step, which also makes debugging these type of build failures much more straight-forward. Ref: https://github.com/shivammathur/setup-php?tab=readme-ov-file#fail-fast-optional
jrfnl
added
yoast cs/qa
changelog: non-user-facing
Pull Request Test Coverage Report for Build fb97ff516ab5e5181ee229d27751530a3c12ab20Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Setup-PHP will normally "gracefully" show a warning and not the build when an extension or tool failed to install.
This is not particularly useful as that means that either there will be a failure later on in the build due to the extension or tool missing, or the build will not be representative of what is supposed to be tested.
This commit changes this behaviour to fail the build at the
setup-phpstep, which also makes debugging these type of build failures much more straight-forward.Ref: https://github.com/shivammathur/setup-php?tab=readme-ov-file#fail-fast-optional
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps: