Conversation
…6.5 support dependencies.
enricobattocchi
added
the
changelog: non-user-facing
Pull Request Test Coverage Report for Build f3112efe224e778803d09bf63e630ecef07a21feDetails
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the block editor integration by removing legacy compatibility code and enhancing error handling. The changes simplify the code that manages the initial opening of the Yoast SEO document panel in the WordPress block editor.
Changes:
- Removed legacy code path for WordPress versions prior to 6.5
- Added null check to prevent errors when
openPanelsis undefined - Simplified the logic to use only the current WordPress API
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JorPV
reviewed
Jan 13, 2026
| const openPanels = select( "core/preferences" )?.get( "core", "openPanels" ); | ||
|
|
||
| if ( ! openPanels.includes( PANEL_NAME ) ) { | ||
| if ( openPanels && ! openPanels.includes( PANEL_NAME ) ) { |
Contributor
There was a problem hiding this comment.
Maybe add a safe Array.isArray() to handle the case where the preference might not be an array (they can be of any type)? 🤔 Or is it over-cautious?
Member
Author
There was a problem hiding this comment.
I don't think it's needed, for this preference it's assumed to be an Array and the editor would probably break before us
Contributor
|
CR + AT ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
grunt build:imagesand commited the results, if my PR introduces new images or SVGs.Innovation
innovationlabel.Fixes #