Add integration tests for analytics adapter

[leonidasmi]

Context

Summary

This PR can be summarized in the following changelog entry:

• Adds integration tests for analytics adapter.

Relevant technical choices:

• We used to try and test also how Site Kit responds when a user that hasn't authenticated its modules with their Google account tries to request our integration data. This has now been removed due to inherent restrictions of our integration tests. In more detail:
  • Because we're working with the external Site Kit plugin which registers its endpoints upon init and the way we require that plugin means that it happens after init has been fired, we had to re-trigger init ourselves (which is something we dont want).
  • To avoid re-triggering init, we have to manually use Site Kit's classes to register its endpoints, but this gets a bit messy: 00d428c
  • To conclude,we removed all that, thus making the PR test mostly our side of things (aka, the way we handle mocked responses from Site Kit's), and if we still want to test Site Kit's side and predictability, we can put more prio to the other automated testing task.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• N/A

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
• This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.
• I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #

[coveralls]

Pull Request Test Coverage Report for Build c571f6f7c0a3ddedbd56c66f8b514ca25a1a9017

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 13 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.4%) to 52.949%

---

Files with Coverage Reduction	New Missed Lines	%
src/generators/schema/howto.php	4	93.75%
src/integrations/blocks/structured-data-blocks.php	9	12.5%

Totals
Change from base Build ff2f33de1ce7594487c7285b42c46e5570ceee1c:	-0.4%
Covered Lines:	32390
Relevant Lines:	61220

---

💛 - Coveralls

[github-actions]

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

[vraja-pro]

• The class that is being tested is Site_Kit_Analytics_4_Adapter but the folder name is Analytics_4, I would expect to have a folder in Analytics_4 named Site_Kit_Analytics_4_Adapter and the tests file name should be names only after the method that is being tested without the prefix.
• get_period method was not covered with tests.

[leonidasmi]

The class that is being tested is Site_Kit_Analytics_4_Adapter but the folder name is Analytics_4, I would expect to have a folder in Analytics_4 named Site_Kit_Analytics_4_Adapter and the tests file name should be names only after the method that is being tested without the prefix

that's exactly what we're doing with the tests of the other module's adapter, Search_Console_Adapter in the very same folder, I'd leave it as is.

For covering get_period(), I pushed a couple of commits.

[vraja-pro]

CR ✅ coverage 💯