Skip to content

Make sure annotation for gutenberg is not available when select( "core/editor" ) is not defined#22889

Merged
JorPV merged 1 commit intorelease/26.8from
2813-blocker-classic-uncaught-typeerror-cannot-read-properties-of-undefined-reading-getrenderingmode-on-click-on-eye-btn
Jan 14, 2026
Merged

Make sure annotation for gutenberg is not available when select( "core/editor" ) is not defined#22889
JorPV merged 1 commit intorelease/26.8from
2813-blocker-classic-uncaught-typeerror-cannot-read-properties-of-undefined-reading-getrenderingmode-on-click-on-eye-btn

Conversation

@FAMarfuaty
Copy link
Copy Markdown
Contributor

@FAMarfuaty FAMarfuaty commented Jan 14, 2026

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an unreleased bug where clicking on the highlighting buttons inside Classic Editor triggered a console error.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Install and activate Yoast SEO
  • Install and activate Classic editor
  • Create a post/page
  • Add some content with many very long sentences (more than 21 words)
  • Click on the highlighting button of the sentence length assessment
  • Confirm that you don't get the following error:
Screenshot 2026-01-14 at 12 20 29
  • Confirm that the long sentences are highlighted
  • Set the keyphrase
  • Add the keyphrase to the content
  • Click on the highlighting button of the keyphrase assessment
  • Confirm that the keyphrase occurrences are highlighted

Impact check

  • Smoke test highlighting feature in Block Editor

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • N/A

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/2813

@FAMarfuaty FAMarfuaty marked this pull request as ready for review January 14, 2026 11:23
@FAMarfuaty FAMarfuaty added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jan 14, 2026
@FAMarfuaty FAMarfuaty added this to the 26.8 milestone Jan 14, 2026
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build d6e8ff0e627067d2dfef294145be9d41ba50cfcb

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.314%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/decorator/gutenberg.js 0 1 0.0%
Totals Coverage Status
Change from base Build be7ce43385dd2ac0b9fdf8e19ba33173878154fd: 0.0%
Covered Lines: 32856
Relevant Lines: 61810

💛 - Coveralls

@JorPV
Copy link
Copy Markdown
Contributor

JorPV commented Jan 14, 2026

CR + AT ✅

@JorPV JorPV merged commit 9957394 into release/26.8 Jan 14, 2026
22 of 24 checks passed
@JorPV JorPV deleted the 2813-blocker-classic-uncaught-typeerror-cannot-read-properties-of-undefined-reading-getrenderingmode-on-click-on-eye-btn branch January 14, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants