Skip to content

Fix error for task list opt in#22893

Merged
leonidasmi merged 1 commit intorelease/26.8from
2817-task-list-opt-in-bug
Jan 19, 2026
Merged

Fix error for task list opt in#22893
leonidasmi merged 1 commit intorelease/26.8from
2817-task-list-opt-in-bug

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Jan 16, 2026

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an unreleased bug where console error would appear when navigating to task list tab while the task list opt-in is rendered.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • If it's not new site, reset task list opt-in by deleteing the user meta _yoast_wpseo_task_list_opt_in_notification_seen
  • Go to general page dashboard.
  • Open the devtools console.
  • Check you see the task list opt in.
  • Do not dismiss it and navigate to the Task list tab
  • Check you see no error.
  • Reset the opt in
  • Refresh the page when you are on the task list tab
  • Check you don't see the opt-in
  • Navigate to dashboard tab.
  • Check you see the opt in (in contrast to the test instructions in 921 add introduction toast to increase task list visibility #22836)

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/2817

@vraja-pro vraja-pro added this to the 26.8 milestone Jan 16, 2026
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jan 16, 2026
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 62e567024558d8f6a4b689d1596d1f152057f6d6

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 53.32%

Totals Coverage Status
Change from base Build 2f11acf61cda5db1e2dddddb1b2fe91e156b7329: 0.006%
Covered Lines: 32856
Relevant Lines: 61805

💛 - Coveralls

@leonidasmi leonidasmi assigned leonidasmi and unassigned leonidasmi Jan 19, 2026
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + Acceptance is ✅

@leonidasmi leonidasmi merged commit c06a25e into release/26.8 Jan 19, 2026
21 checks passed
@leonidasmi leonidasmi deleted the 2817-task-list-opt-in-bug branch January 19, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants