Skip to content

Add deprecated method for BC#22901

Merged
leonidasmi merged 2 commits intotrunkfrom
496-remove-load_plugin_textdomain-deprecation
Jan 22, 2026
Merged

Add deprecated method for BC#22901
leonidasmi merged 2 commits intotrunkfrom
496-remove-load_plugin_textdomain-deprecation

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Jan 21, 2026

Context

  • We want to add a deprecated method for BC purposes

Summary

This PR can be summarized in the following changelog entry:

  • Adds a deprecated message for the now unneeded wpseo_load_textdomain method.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Smoke test the plugin and make sure you don't see the deprecated method called.
  • Have a add_action( 'plugins_loaded', 'wpseo_load_textdomain' ); snippet added in your site and confirm that there's no fatals thrown, just a deprecation message.

Dev only:
To be double sure re-run the #22245 test instructions.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jan 21, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 21, 2026

Pull Request Test Coverage Report for Build c36c3db8f6ab85bf79f792315503eac0ea0954db

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 52.837%

Totals Coverage Status
Change from base Build 52a2952fc1093b225ec9b17ed371651b9f5bed79: -0.5%
Covered Lines: 32310
Relevant Lines: 61218

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + Acceptance is ✅

Comment thread wp-seo-main.php Outdated
@leonidasmi leonidasmi added this to the 27.0 milestone Jan 22, 2026
@leonidasmi leonidasmi merged commit 8d4dbc5 into trunk Jan 22, 2026
27 checks passed
@leonidasmi leonidasmi deleted the 496-remove-load_plugin_textdomain-deprecation branch January 22, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants