Make sure the content-analysis-api app still works with Parse5#22909
Merged
agnieszkaszuba merged 2 commits intotrunkfrom Jan 26, 2026
Merged
Make sure the content-analysis-api app still works with Parse5#22909agnieszkaszuba merged 2 commits intotrunkfrom
agnieszkaszuba merged 2 commits intotrunkfrom
Conversation
… to enable interoperability between CommonJS and ESM without bundling
Pull Request Test Coverage Report for Build 723511cab22b33e08430cd042c7aa48c800e7bb9Details
💛 - Coveralls |
Contributor
|
CR & acceptance: 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
startscript inpackage.jsonofapps/content-analysis-apito include the--experimental-require-moduleflag, enabling experimental module loading features when starting the application..nvmrcfile insideapps/content-analysis-apispecifying Node.js version22for the project.Relevant technical choices:
startscript inside this app, I added--experimental-require-moduleflag. This will allowrequire()to load ES modules, enabling interoperability between CommonJS and ESM without bundling..nvmrcfile inside app and set it to 22. So this means that one needs to switch to node 22 when using the app, e.g. runnvm use--experimental-require-moduleas in the name, the flag may change or be removed in future Node versions. We decide the impact is not too critical which we can address it later when the flag is actually removed or changed.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Only for devs
apps/content-analysis-apinvm useyarn && yarn startand confirm that the app still works as expectedprompt-engineeringrepoRelevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
grunt build:imagesand commited the results, if my PR introduces new images or SVGs.Innovation
innovationlabel.Fixes #