Skip to content

Fix task list selector for completed and total tasks.#22964

Merged
FAMarfuaty merged 2 commits intofeature/task-list-phase-2from
1061-task-list-frontend-progress-bar-at-main-list-view-shouldnt-account-for-child-tasks
Feb 11, 2026
Merged

Fix task list selector for completed and total tasks.#22964
FAMarfuaty merged 2 commits intofeature/task-list-phase-2from
1061-task-list-frontend-progress-bar-at-main-list-view-shouldnt-account-for-child-tasks

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Feb 11, 2026

Context

  • We want to fix the values for the task list main progress bar to not include child tasks.

Summary

This PR can be summarized in the following changelog entry:

  • Updates the main progress bar in the task list to include only parent tasks.

Relevant technical choices:

  • I added a flag for including the child tasks in the selector.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to Yoast SEO -> General -> Task list
  • Check the progress bar includes only parent tasks and parent completed tasks.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Task-list [frontend]: Progress bar at main list view shouldnt account for child tasks

* Fixed implementation
* Updated tests
@vraja-pro vraja-pro added this to the feature/task-list-phase-2 milestone Feb 11, 2026
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Feb 11, 2026
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build baa39c382fd2624513e843baa73a9f0697492944

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 53.577%

Totals Coverage Status
Change from base Build 00a7e557e94807e7b2159f3d3ad785c6b19a3033: 0.01%
Covered Lines: 33383
Relevant Lines: 62457

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@FAMarfuaty FAMarfuaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat solution! 🙌🏽

@FAMarfuaty FAMarfuaty merged commit 70b457e into feature/task-list-phase-2 Feb 11, 2026
21 checks passed
@FAMarfuaty FAMarfuaty deleted the 1061-task-list-frontend-progress-bar-at-main-list-view-shouldnt-account-for-child-tasks branch February 11, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants