Exclude non indexable post types and robots noindex posts#22998
Closed
Exclude non indexable post types and robots noindex posts#22998
Conversation
…he-get-xml-endpoint 864 add indexable fallback for the get xml endpoint
…646-differentiate-pagination-strategy-for-products # Conflicts: # src/schema-aggregator/application/aggregate-site-schema-map-command-handler.php # src/schema-aggregator/application/schema_map/schema-map-builder.php
…ategy-for-products Make the max amount per page based on the post type.
…s-seo into 884-include-yoast-woocommerce-product-schema-in-the-aggregated-schema
…restrict-schema-elements-to-content-only
…oduct-schema-in-the-aggregated-schema Allow for woo schema to be added to our graph.
…chema_aggregator # Conflicts: # admin/tracking/class-tracking-settings-data.php # inc/options/class-wpseo-option-wpseo.php
Comprehensive test coverage for the Indexable_Count value object including: - Constructor property initialization - get_count() with various count values (zero, positive, negative, large) - get_post_type() with different post type formats - Integration tests verifying getters return constructor values 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Comprehensive test coverage for the Indexable_Count_Collection class including: - Constructor initializes empty collection - add_indexable_count() adds items correctly - get_indexable_counts() returns correct array - Collection maintains insertion order - Tests for empty, single, and multiple items 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Comprehensive test coverage for the Page_Controls value object including: - Constructor sets page, page_size, and post_type properties - get_page() with various page numbers - get_page_size() with different page size values - get_post_type() with various post type formats - Integration tests verifying all getters return constructor values 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit edbfc01.
…tegration-tests Add schema piece repositories integration tests
…ories-unit-tests Add missing schema piece repositories unit tests
Add miscellaneous unit tests
…a-xml-map Add tests
…eature/schema_aggregator
Also avoid listing that endpoint in the schemamap
composer.lockDev Package changes
Settings · Docs · Powered by Private Packagist |
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
Member
Author
|
Duplicated PR by mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
YOU-SITE-URL/wp-json/yoast/v1/schema-aggregator/get-xmlYoast SEO->SettingsContent typessection, select a post typeShow events in search resultstoofffor that post typeYOU-SITE-URL/wp-json/yoast/v1/schema-aggregator/get-xmlagainShow events in search resultsis set tooffdoesn't appear in the endpoints listRelevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
grunt build:imagesand commited the results, if my PR introduces new images or SVGs.Innovation
innovationlabel.Fixes #