Skip to content

Exclude non indexable post types and robots noindex posts#22998

Closed
pls78 wants to merge 392 commits intotrunkfrom
exclude-non-indexable-post-types-and-robots-noindex-posts
Closed

Exclude non indexable post types and robots noindex posts#22998
pls78 wants to merge 392 commits intotrunkfrom
exclude-non-indexable-post-types-and-robots-noindex-posts

Conversation

@pls78
Copy link
Copy Markdown
Member

@pls78 pls78 commented Feb 17, 2026

Context

Summary

This PR can be summarized in the following changelog entry:

Relevant technical choices:

  • N/A

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Visit YOU-SITE-URL/wp-json/yoast/v1/schema-aggregator/get-xml
    • Take not of the endpoints returned
  • Go to Yoast SEO -> Settings
    • In the Content types section, select a post type
    • Toggle Show events in search results to off for that post type
  • Clear your site transients
  • Visit YOU-SITE-URL/wp-json/yoast/v1/schema-aggregator/get-xml again
    • Verify the post type Show events in search results is set to off doesn't appear in the endpoints list
  • Visit the missing endpoint
    • Verify you get a 404 response stating as follows:
      {
        "code":"wpseo_post_type_not_indexable",
        "message":"The post type \"EXCLUDED-POST-TYPE-NAME" is excluded from search results.",
        "data":
          {
            "status":404
         }
      }
    

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

pls78 and others added 30 commits November 28, 2025 16:36
…he-get-xml-endpoint

864 add indexable fallback for the get xml endpoint
…646-differentiate-pagination-strategy-for-products

# Conflicts:
#	src/schema-aggregator/application/aggregate-site-schema-map-command-handler.php
#	src/schema-aggregator/application/schema_map/schema-map-builder.php
…ategy-for-products

Make the max amount per page based on the post type.
…s-seo into 884-include-yoast-woocommerce-product-schema-in-the-aggregated-schema
…oduct-schema-in-the-aggregated-schema

Allow for woo schema to be added to our graph.
…chema_aggregator

# Conflicts:
#	admin/tracking/class-tracking-settings-data.php
#	inc/options/class-wpseo-option-wpseo.php
Comprehensive test coverage for the Indexable_Count value object including:
- Constructor property initialization
- get_count() with various count values (zero, positive, negative, large)
- get_post_type() with different post type formats
- Integration tests verifying getters return constructor values

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Comprehensive test coverage for the Indexable_Count_Collection class including:
- Constructor initializes empty collection
- add_indexable_count() adds items correctly
- get_indexable_counts() returns correct array
- Collection maintains insertion order
- Tests for empty, single, and multiple items

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Comprehensive test coverage for the Page_Controls value object including:
- Constructor sets page, page_size, and post_type properties
- get_page() with various page numbers
- get_page_size() with different page size values
- get_post_type() with various post type formats
- Integration tests verifying all getters return constructor values

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@private-packagist
Copy link
Copy Markdown

composer.lock

Dev Package changes

Package Operation From To About
wpackagist-plugin/easy-digital-downloads add - dev-trunk - - License: UNLICENSED
wpackagist-plugin/woocommerce add - dev-trunk - - License: UNLICENSED

Settings · Docs · Powered by Private Packagist

@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

@pls78 pls78 added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog and removed merge conflict labels Feb 17, 2026
@pls78 pls78 added this to the feature/schema-aggregation milestone Feb 17, 2026
@pls78
Copy link
Copy Markdown
Member Author

pls78 commented Feb 17, 2026

Duplicated PR by mistake.

@pls78 pls78 closed this Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants