Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Premium plugin’s JS dependency on @yoast/ai-frontend to a newer version so Premium can use newly introduced UI/components from that package (and its updated transitive Yoast UI dependencies).
Changes:
- Bump
@yoast/ai-frontendfrom^0.19.0to^0.24.0inpackages/js/package.json. - Update
yarn.lockto lock@yoast/ai-frontend@0.24.0and updated transitive Yoast packages.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/js/package.json |
Updates the declared dependency range for @yoast/ai-frontend to ^0.24.0. |
yarn.lock |
Updates the lockfile entries for @yoast/ai-frontend@0.24.0 and related transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The abbrev package entry was incorrectly merged with array-flatten during dependency deduplication, causing yarn install to populate node_modules/abbrev with array-flatten's code. This broke grunt (via nopt -> abbrev) on CI with a fresh install.
Contributor
|
LGTM ✅ |
Pull Request Test Coverage Report for Build 336bab5a4236c135d2b1d938fe323e01e64f61edWarning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We want to use new components from ai-frontend in premium. This bumps
@yoast/ai-frontendfrom^0.19.0to^0.24.0.Summary
This PR can be summarized in the following changelog entry:
@yoast/ai-frontendto0.24.0to enable new components for premium.Relevant technical choices:
@yoast/ai-frontendfrom^0.19.0to^0.24.0, which also updates transitive dependencies (@yoast/search-metadata-previews,@yoast/social-metadata-previews,@yoast/ui-library).Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
grunt build:imagesand commited the results, if my PR introduces new images or SVGs.Innovation
innovationlabel.Fixes #