Skip to content

Removes ZEBRA_NETWORK__NETWORK env var from Run all tests#9830

Merged
gustavovalverde merged 2 commits intofeat-config-rsfrom
suggestion-for-feat-config-rs
Aug 26, 2025
Merged

Removes ZEBRA_NETWORK__NETWORK env var from Run all tests#9830
gustavovalverde merged 2 commits intofeat-config-rsfrom
suggestion-for-feat-config-rs

Conversation

@arya2
Copy link
Copy Markdown
Contributor

@arya2 arya2 commented Aug 25, 2025

This PR is intended to run the Run all tests CI job without the ZEBRA_NETWORK__NETWORK environment variable.

It can be merged into #9768 by @gustavovalverde if it passes. There are also suggestions on that PR that would make the same changes which could be applies instead of merging this PR.

One of the failings tests has passed here.

@github-actions github-actions bot added C-feature Category: New features extra-reviews This PR needs at least 2 reviews to merge labels Aug 25, 2025
@arya2 arya2 marked this pull request as ready for review August 26, 2025 02:45
@arya2 arya2 requested review from a team as code owners August 26, 2025 02:45
@arya2 arya2 requested review from gustavovalverde and oxarbitrage and removed request for a team August 26, 2025 02:45
@arya2 arya2 added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG and removed C-feature Category: New features extra-reviews This PR needs at least 2 reviews to merge labels Aug 26, 2025
@gustavovalverde gustavovalverde merged commit 2a8776e into feat-config-rs Aug 26, 2025
7 checks passed
@gustavovalverde gustavovalverde deleted the suggestion-for-feat-config-rs branch August 26, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants