Add `source=survey` to the changeset, not elements

[maro-21]

Please add source=survey to the tags of the changeset, not to node/way/relation, because source=survey means that all tags, including geometry, come from the survey.

Example edit:
https://overpass-api.de/achavi/?changeset=154903520

[mcliquid]

The tag is not set automatically, but manually by the user.
This is a field that is most likely provided by the iD tagging scheme and like any other field must be explicitly selected by the user:

This is available here in the iD editor as well and is set when it is filled out:

In my view, no bug in Every Door.

[maro-21]

There is nothing to compare to iD, because iD is an extended editor, while EveryDoor is a simple one.

The user adds source=survey, but this tag should be in the tags of the changeset, for the reasons I mentioned earlier.

See also https://wiki.openstreetmap.org/wiki/Key:source

[Zverik]

Every Door adds source=survey neither to changesets, nor to elements. It can be easily verified by searching "survey" in this repository. For the object in question, a user must have added the tag by hand, as @mcliquid suggested.

Every Door uses the same tagging preset database as iD, so confirming forms with iD is valid.

[maro-21]

I see.
I saw many such edits by this user so I thought it comes from the editor.

[tordans]

I created openstreetmap/id-tagging-schema#1469 to find out why we actually have this field as a tagging recommendation.

Every Door uses the same tagging preset database as iD, so confirming forms with iD is valid.

I do consider the situation for every door a bit different from iD because its easier to discover the field. But the questions why we actually recommend it is the more important one :).

[Zverik]

I do consider the situation for every door a bit different from iD because its easier to discover the field.

Frankly I'd take that as an issue with iD user interface. Additional tags should be easier discoverable :)