Skip to content

fix: normalize gRPC agent card URLs#25

Merged
muscariello merged 1 commit intomainfrom
fix/grpc-agent-card-url-normalization
Apr 5, 2026
Merged

fix: normalize gRPC agent card URLs#25
muscariello merged 1 commit intomainfrom
fix/grpc-agent-card-url-normalization

Conversation

@muscariello
Copy link
Copy Markdown
Member

Summary

This completes the remaining Rust-side gRPC interop fix by normalizing published gRPC agent-card interface URLs.

  • canonicalize GRPC interface URLs by stripping plaintext http:// on construction and wire serialization/deserialization
  • apply the same normalization in protobuf agent interface conversion so JSON and protobuf card paths stay aligned
  • add regression tests for gRPC interface normalization and related error/status mappings used to keep overall line coverage above the current target

Context

The previously released Rust gRPC fix made the client tolerant of bare host:port endpoints. The remaining gap was on the publication side: Rust still emitted http://host:port in gRPC agent cards, which Go rejects for gRPC transport discovery. This change fixes that outbound card representation.

https:// URLs are intentionally preserved so TLS intent is not discarded.

Testing

  • cargo fmt --all --check
  • cargo test --workspace
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo llvm-cov --workspace --summary-only --ignore-filename-regex gen/ (95.08% line coverage)

Signed-off-by: Luca Muscariello <[email protected]>
@muscariello muscariello requested a review from a team as a code owner April 5, 2026 22:09
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@muscariello muscariello merged commit a588c09 into main Apr 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants