Merged
Conversation
Signed-off-by: Luca Muscariello <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This completes the remaining Rust-side gRPC interop fix by normalizing published gRPC agent-card interface URLs.
GRPCinterface URLs by stripping plaintexthttp://on construction and wire serialization/deserializationContext
The previously released Rust gRPC fix made the client tolerant of bare
host:portendpoints. The remaining gap was on the publication side: Rust still emittedhttp://host:portin gRPC agent cards, which Go rejects for gRPC transport discovery. This change fixes that outbound card representation.https://URLs are intentionally preserved so TLS intent is not discarded.Testing
cargo fmt --all --checkcargo test --workspacecargo clippy --workspace --all-targets -- -D warningscargo llvm-cov --workspace --summary-only --ignore-filename-regex gen/(95.08%line coverage)