Skip to content

fix(interop): align push-config JSON bindings with a2a-go#31

Merged
muscariello merged 1 commit intomainfrom
feat/push-config-response-interop
Apr 6, 2026
Merged

fix(interop): align push-config JSON bindings with a2a-go#31
muscariello merged 1 commit intomainfrom
feat/push-config-response-interop

Conversation

@muscariello
Copy link
Copy Markdown
Member

Summary

  • align JSON-RPC and REST push-config responses with the JSON shapes expected by a2a-go
  • keep Rust JSON-RPC and REST clients backward-compatible with the older ProtoJSON push-config payloads during rollout
  • return HTTP 200 for REST push-config deletes and cover the positive delete path in server tests

Validation

  • cargo fmt --all -- --check
  • cargo test -p agntcy-a2a-server
  • cargo test --workspace
  • cargo clippy --workspace --all-targets -- -D warnings

@muscariello muscariello requested a review from a team as a code owner April 6, 2026 17:27
@muscariello muscariello merged commit 8921205 into main Apr 6, 2026
4 of 5 checks passed
@muscariello muscariello deleted the feat/push-config-response-interop branch April 6, 2026 17:28
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.13260% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
a2a-client/src/push_config_compat.rs 94.73% 4 Missing ⚠️
a2a-client/src/rest.rs 93.10% 2 Missing ⚠️
a2a-server/src/rest.rs 97.87% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions github-actions bot mentioned this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants