Skip to content

fix(client): serialize create-push requests for go interop#35

Merged
muscariello merged 3 commits intomainfrom
feat/push-config-request-interop
Apr 6, 2026
Merged

fix(client): serialize create-push requests for go interop#35
muscariello merged 3 commits intomainfrom
feat/push-config-request-interop

Conversation

@muscariello
Copy link
Copy Markdown
Member

Summary

  • serialize JSON-RPC create-push requests with the nested SDK request shape expected by a2a-go
  • keep the existing ProtoJSON path for other request types and reuse the generic JSON-RPC result handling
  • add a focused compatibility test covering the nested create-push request payload

Validation

  • cargo test -p agntcy-a2a-client
  • cargo test --workspace
  • cargo clippy --workspace --all-targets -- -D warnings

@muscariello muscariello requested a review from a team as a code owner April 6, 2026 20:11
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 96.65272% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
a2a-client/src/jsonrpc.rs 97.11% 6 Missing ⚠️
a2a-client/src/push_config_compat.rs 93.54% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: Luca Muscariello <muscariello@ieee.org>
@muscariello muscariello force-pushed the feat/push-config-request-interop branch from 43d1083 to 7389ebe Compare April 6, 2026 20:15
Signed-off-by: Luca Muscariello <muscariello@ieee.org>
Signed-off-by: Luca Muscariello <muscariello@ieee.org>
@muscariello muscariello merged commit aedf04d into main Apr 6, 2026
5 checks passed
@github-actions github-actions bot mentioned this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants