fix: inherit subagent provider and model overrides#8497
Open
AiRC-ai wants to merge 1 commit intoaaif-goose:mainfrom
Open
fix: inherit subagent provider and model overrides#8497AiRC-ai wants to merge 1 commit intoaaif-goose:mainfrom
AiRC-ai wants to merge 1 commit intoaaif-goose:mainfrom
Conversation
Signed-off-by: Ryan Cox <ryancox@GoDSyNcs-MBP.godsync.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change ensures that subagents correctly inherit provider and model configurations when explicit overrides are not provided.
It introduces a consistent normalization and resolution flow that:
"inherit"(including whitespace variations) as no overrideGOOSE_SUBAGENT_PROVIDER,GOOSE_SUBAGENT_MODEL)Key Changes
normalize_delegate_overrideto sanitize override valuesresolve_delegate_provider_namefor provider resolutionresolve_delegate_model_overridefor model resolution"inherit"from metadata-derived labelsSummonClientto use centralized helpers"inherit"does not propagate into runtime configurationBehavior Improvements
"inherit"from being treated as a literal provider/modelTesting
Added tests to validate:
"inherit"is ignored in agent frontmatter"inherit"does not produce recipe settings"inherit""inherit"Notes
This change improves consistency and reduces edge cases where invalid or unintended configuration values could be applied during subagent execution.