inherit delegated model selection and improve Ollama Cloud flow#8500
inherit delegated model selection and improve Ollama Cloud flow#8500AiRC-ai wants to merge 5 commits intoaaif-goose:mainfrom
Conversation
Signed-off-by: Ryan Cox <ryancox@GoDSyNcs-MBP.godsync.com>
Signed-off-by: Abhijay Jain <Abhijay007j@gmail.com>
Signed-off-by: Abhijay Jain <Abhijay007j@gmail.com>
Signed-off-by: Ryan Cox <ryancox@GoDSyNcs-MBP.godsync.com>
Signed-off-by: Ryan Cox <ryancox@GoDSyNcs-MBP.godsync.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37d221228b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !existing_config.api_key_env.is_empty() { | ||
| let _ = config.delete_secret(&existing_config.api_key_env); | ||
| } |
There was a problem hiding this comment.
Avoid deleting shared API key when disabling fixed-provider auth
In update_custom_provider, the non-editable requires_auth == false branch deletes existing_config.api_key_env and then drops any shadow override. For fixed declarative providers that still default to requires_auth: true, this means the disable-auth toggle is not actually persisted, but the stored secret is still erased, so the provider will fail on next use; this can also break other providers that reuse the same env var key (for example MOONSHOT_API_KEY). Persist an explicit auth override or avoid deleting the secret in this path.
Useful? React with 👍 / 👎.
Summary
inheritas a sentinel for delegated provider/model selection so subagents correctly fall back to the active parent session instead of passinginheritthrough literallyollama_cloudto canonical metadata so context limits and related model metadata resolve correctlyValidation
cargo fmt --allcargo test -p goose summon -- --test-threads=1cargo test -p goose declarative_providers -- --test-threads=1cargo test -p goose test_map_to_canonical_model -- --test-threads=1cargo test -p goose with_canonical_limits -- --test-threads=1source bin/activate-hermit && cd ui/desktop && pnpm run typechecksource bin/activate-hermit && just package-uiManual verification
inheritis specifiedNotes
This branch combines the tested subagent inheritance fixes with the Ollama Cloud and declarative provider flow improvements into a single reviewable change set.