Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30293388c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| set -euo pipefail | ||
|
|
||
| if [[ -z "${GOOSE_BIN:-}" ]]; then | ||
| export GOOSE_BIN="$(cargo metadata --format-version 1 | jq -r '.target_directory')/debug/goose" |
There was a problem hiding this comment.
Remove undeclared jq dependency from dev startup
This new GOOSE_BIN assignment shells cargo metadata through jq, but ui/goose2 setup only provisions project tools (pnpm/Rust/etc.) and does not install jq. On environments without jq (for example many default macOS setups), both just dev and just dev-debug now fail immediately with jq: command not found, which is a regression from the previous recipes that did not require this extra binary. Please parse cargo metadata without jq or add jq to the managed toolchain.
Useful? React with 👍 / 👎.
... with a just recipe to build from the repo root