Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fb65b3b70
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const nameW = Math.max(16, Math.floor(layoutW * 0.30)); | ||
| const descW = Math.max(8, layoutW - 2 - STATUS_W - nameW - 2 * GUTTER); | ||
|
|
||
| const rows = Math.max(height - 9, 4); |
There was a problem hiding this comment.
Recalculate rows when warnings are rendered
rows is fixed to height - 9, but the screen can also render a variable-height warnings block and scroll indicators below the list. When warnings are present (for example, extension config warnings), the list still slices/render rows as if that space were free, and Ink does not clip overflow, so list content can bleed into the warnings/footer area. The row budget should subtract dynamic warning/indicator lines before computing windowed.
Useful? React with 👍 / 👎.
Summary
Testing
Manual usage
Related Issues
#6642
Screenshots/Demos (for UX changes)