Skip to content

fix(embed): mark all tokens for output to suppress llama.cpp 'overriding' warning (#2208) #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anai-Guo wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix(embed): mark all tokens for output to suppress llama.cpp 'overriding' warning (#2208) #2209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llama_cpp/llama.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,7 +1040,8 @@ def embed(

# get pooling information
pooling_type = self.pooling_type()
logits_all = pooling_type == llama_cpp.LLAMA_POOLING_TYPE_NONE
# All tokens need outputs for embeddings; llama.cpp otherwise logs an "overriding" warning per input.
logits_all = True

if self.context_params.embeddings is False:
raise RuntimeError(
Expand Down
Loading
⚡