Add puppetdb manage dbserver by chrisowensboston · Pull Request #125 · abstractitptyltd/abstractit-puppet

chrisowensboston · 2016-11-02T20:45:04Z

Added manage_dbserver param to profile/puppetdb, to make it consistent with profile/master.

rendhalver · 2016-11-02T20:47:03Z

Can you also remove the Gemfile.lock changes from this please.

chrisowensboston · 2016-11-02T21:11:30Z

I probably can’t get to that until tomorrow. Stand by.

From: Pete Brown [mailto:notifications@github.com]
Sent: 11/02/2016 4:47 PM
To: abstractitptyltd/abstractit-puppet abstractit-puppet@noreply.github.com
Cc: chrisowensboston ctag@chris-owens.com; Author author@noreply.github.com
Subject: Re: [abstractitptyltd/abstractit-puppet] Add puppetdb manage dbserver (#125)

Can you also remove the Gemfile.lock changes from this please.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #125 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AQKb58iSqL3EhrbP9mlB0wMeOV_Ar1aUks5q6PbIgaJpZM4Knuin . https://github.com/notifications/beacon/AQKb50_a7-UNbQzJeQ-qzVSDzY51GVuPks5q6PbIgaJpZM4Knuin.gif

rendhalver · 2016-11-03T18:28:37Z

            :disable_ssl        => false,
            :listen_address     => '127.0.0.1',
            :ssl_listen_address => '0.0.0.0',
+            :manage_dbserver    => true,


Can you also add a test for when this is not set.

Adding that test surfaced a bug in the puppetlabs/postgresql module: https://tickets.puppetlabs.com/browse/MODULES-4054.

Ouch.
Maybe we need to looks at later versions of the module.
I will have a look later and se what we can do about this.

Given discussion in main thread lets leave this for now.

Where is discussion?

rendhalver · 2016-11-03T18:29:08Z

 in Gemfile, forced json_pure to be < 2.0.1 when ruby < 2.0 @chrisowensboston
 in .travis.yml, added a line for rvm 2.2.0, puppet gem 4.7.0, facter gem 2.4.6, hiera gem 3.2.1 @chrisowensboston

-


You can remove your changes to this file too.

chrisowensboston · 2016-11-04T17:01:50Z

The problem is probably theoretical… it occurs in testing, because declaring puppet::profile::puppetdb with manage_dbserver false, invokes the puppetdb class with manage_dbserver false, which declares an instance of postgresql::server::db but (because it’s not trying to manage the server) does not declare postgresql::server.

In actual deployments, the the likely reason for setting manage_dbserver to false would be because you’re managing the Postgresql server out of some other catalog entry, i.e. postgresql::server is going to be declared on that host somewhere, somehow. The exception would be a host that has a postgresql server on it that is not under the control of puppet.

I’m not sure what the right answer would be. I don’t love the whole postgresql::globals pattern, but perhaps the right thing would be for postgresql::server::db and friends to include postgresql::globals and get things like character encoding from that class?

From: Pete Brown [mailto:notifications@github.com]
Sent: 11/04/2016 7:48 AM
To: abstractitptyltd/abstractit-puppet abstractit-puppet@noreply.github.com
Cc: chrisowensboston ctag@chris-owens.com; Author author@noreply.github.com
Subject: Re: [abstractitptyltd/abstractit-puppet] Add puppetdb manage dbserver (#125)

@rendhalver commented on this pull request.

In spec/classes/puppet_profile_puppetdb_spec.rb #125 :

@@ -67,6 +67,7 @@
:disable_ssl => false,
:listen_address => '127.0.0.1',
:ssl_listen_address => '0.0.0.0',
       :manage_dbserver    => true,

Ouch.
Maybe we need to looks at later versions of the module.
I will have a look later and se what we can do about this.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #125 , or mute the thread https://github.com/notifications/unsubscribe-auth/AQKb5y2npg0tBfC87z-ya-qAgYhR8vo0ks5q6xtbgaJpZM4Knuin . https://github.com/notifications/beacon/AQKb53KC9W7c_68Ufkg90FYMhScON6S0ks5q6xtbgaJpZM4Knuin.gif

rendhalver · 2016-11-04T17:36:42Z

Yeah that makes sense.
Annoying but it explains what the issue is.
I think I did run into something similar when I was trying to spec test puppetdb in this module.
Maybe we should just leave it off the tests and trust that puppet is testing things properly.

chrisowensboston · 2017-02-01T20:49:41Z

I can't make sense of the pull request chronology... are you still waiting for changes from me?

* Attempt to fix Travis builds * Adjust travis version matrix

* Drop log format config for puppetsyntax * Set max version for puppetserevr_gem * Lock puppet-syntax to 2.1.0 * Lock puppet-lint to 2.0.2 * lock concat to 1.2.2 * Code cleanup * cleanup versions

rendhalver · 2017-04-01T16:53:46Z

@chrisowensboston Please rebase and remove your changes to the CHANGELOG.md

chrisowensboston · 2017-04-05T03:51:31Z

Sorry, been tied up. Will look at this in the AM. From: Pete Brown [mailto:notifications@github.com] Sent: 04/01/2017 12:54 PM To: abstractitptyltd/abstractit-puppet <abstractit-puppet@noreply.github.com> Cc: chrisowensboston <ctag@chris-owens.com>; Mention <mention@noreply.github.com> Subject: Re: [abstractitptyltd/abstractit-puppet] Add puppetdb manage dbserver (#125) @chrisowensboston <https://github.com/chrisowensboston> Please rebase and remove your changes to the CHANGELOG.md — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#125 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AQKb5-03M3YlOTIVPGC88jEXqtm_nYlGks5rroEagaJpZM4Knuin> . <https://github.com/notifications/beacon/AQKb53tc5rRp_5TeyMCoD9oHvPDMpBz3ks5rroEagaJpZM4Knuin.gif>

chrisowensboston · 2017-04-07T05:45:15Z

Hi Pete (sorry for muddying the waters by replying here but I don’t have an e-mail address for you). Could you help me verify my own sanity by trying this and letting me know what you see? Very oddly, puppet agent v4.9 and 4.10 (at least) seem to read the puppet.conf file differently depending upon whether run as a service or run manually. https://tickets.puppetlabs.com/browse/PUP-7434 Thanks much, /c From: Pete Brown [mailto:notifications@github.com] Sent: 04/01/2017 12:54 PM To: abstractitptyltd/abstractit-puppet <abstractit-puppet@noreply.github.com> Cc: chrisowensboston <ctag@chris-owens.com>; Mention <mention@noreply.github.com> Subject: Re: [abstractitptyltd/abstractit-puppet] Add puppetdb manage dbserver (#125) @chrisowensboston <https://github.com/chrisowensboston> Please rebase and remove your changes to the CHANGELOG.md — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#125 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AQKb5-03M3YlOTIVPGC88jEXqtm_nYlGks5rroEagaJpZM4Knuin> . <https://github.com/notifications/beacon/AQKb53tc5rRp_5TeyMCoD9oHvPDMpBz3ks5rroEagaJpZM4Knuin.gif>

rendhalver · 2017-04-08T18:02:01Z

Interesting.
That's going to break a few setups.
I have been seeing some interesting things on some recent servers that could be explained by that.
Let me do some investigation and get back to you.

rendhalver · 2017-04-08T18:15:17Z

Yep it looks like that is what's happening.
I migrated a few of my servers to a new puppet server recently.
The old server listens on puppet.$::domain. The new servers uses a different address.
The servers I migrated are contacting the old puppet server and getting auth denied.

rendhalver · 2017-04-08T18:37:49Z

@chrisowensboston If you are happy with this I am going to merge it.

rendhalver · 2017-04-08T18:38:30Z

Actually can you please rebase @chrisowensboston ?

chrisowensboston · 2017-04-08T22:59:29Z

Will do Sent from handheld; pls excuse terseness...

…

-------- Original message -------- From: Pete Brown <notifications@github.com> Date: 4/8/17 14:38 (GMT-05:00) To: abstractitptyltd/abstractit-puppet <abstractit-puppet@noreply.github.com> Cc: chrisowensboston <ctag@chris-owens.com>, Mention <mention@noreply.github.com> Subject: Re: [abstractitptyltd/abstractit-puppet] Add puppetdb manage dbserver (#125) Actually can you please rebase @chrisowensboston ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/abstractitptyltd/abstractit-puppet","title":"abstractitptyltd/abstractit-puppet","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/abstractitptyltd/abstractit-puppet"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rendhalver in #125: Actually can you please rebase @chrisowensboston ?"}],"action":{"name":"View Pull Request","url":"#125 (comment)"}}}

…wensboston/abstractit-puppet into add_puppetdb_manage_dbserver

calmenergy · 2017-04-10T04:22:36Z

It's possible that this branch is now munted due to me having made a mess of the rebase.

rendhalver · 2017-04-10T11:41:15Z

Yes it looks like it.
It's best to just setup an upstream remote and sync up your local production branch with that and then do a manual rebase.
I don't use the sync buttons in GitHub at all.
This will show you how to sync a fork: https://help.github.com/articles/syncing-a-fork/

calmenergy · 2017-04-10T16:52:21Z

At this point, my end is such a mess of commits that I’m going to create a new fork of your ‘production’ branch, manually make my changes to that branch, commit all in one, and then do a new PR. From: Pete Brown [mailto:notifications@github.com] Sent: 04/10/2017 7:41 AM To: abstractitptyltd/abstractit-puppet <abstractit-puppet@noreply.github.com> Cc: calmenergy <cowens@calmenergyinc.com>; Comment <comment@noreply.github.com> Subject: Re: [abstractitptyltd/abstractit-puppet] Add puppetdb manage dbserver (#125) Yes it looks like it. It's best to just setup an upstream remote and sync up your local production branch with that and then do a manual rebase. I don't use the sync buttons in GitHub at all. This will show you how to sync a fork: https://help.github.com/articles/syncing-a-fork/ — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#125 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AZMqfsYadIgBZXVVlhAPNmCPMGM95EGQks5ruhVbgaJpZM4Knuin> . <https://github.com/notifications/beacon/AZMqftK2EVDusicb_uQux1xVugdghToKks5ruhVbgaJpZM4Knuin.gif>

rendhalver · 2017-04-10T17:08:47Z

git cherry-pick is a good way to copy commits to a new branch.

calmenergy · 2017-04-10T19:47:01Z

See PR #144

calmenergy added 6 commits November 2, 2016 16:26

Various tweaks and changes described in CHANGELOG.md

d7fd05a

Further bug fixes per changelog

54ad7ca

Various tweaks and changes described in CHANGELOG.md

83d7126

Further bug fixes per changelog

a1ad7b2

Updated Gemfile to limit json_pure version to <2.0.2 when ruby is < 2.0

84ee9d8

Added manage-dbserver param (default true) to profile/puppetdb

079a937

Revert Gemfile.lock

3bab5bc

rendhalver requested changes Nov 3, 2016

View reviewed changes

rendhalver and others added 4 commits March 25, 2017 19:15

Attempt to fix Travis builds (abstractitptyltd#135)

acbaedf

* Attempt to fix Travis builds * Adjust travis version matrix

fix name of puppet group in puppet4 (abstractitptyltd#132)

9570f1f

more travis fixes (abstractitptyltd#137)

828d0d7

* Drop log format config for puppetsyntax * Set max version for puppetserevr_gem * Lock puppet-syntax to 2.1.0 * Lock puppet-lint to 2.0.2 * lock concat to 1.2.2 * Code cleanup * cleanup versions

Add config to setup an ENC (abstractitptyltd#136)

39e4d72

Release version 2.3.0 (abstractitptyltd#138)

68d7516

rendhalver mentioned this pull request Apr 8, 2017

fix puppet agent server setting. #142

Closed

rendhalver approved these changes Apr 8, 2017

View reviewed changes

calmenergy added 2 commits April 10, 2017 04:13

Removed Gemfile.lock

325db6b

Various tweaks and changes described in CHANGELOG.md

7dab796

calmenergy added 6 commits April 10, 2017 04:14

Further bug fixes per changelog

be08136

Various tweaks and changes described in CHANGELOG.md

da803f8

Further bug fixes per changelog

de91afc

Updated Gemfile to limit json_pure version to <2.0.2 when ruby is < 2.0

1e3aab6

Added manage-dbserver param (default true) to profile/puppetdb

1c2473f

Merge branch 'add_puppetdb_manage_dbserver' of ssh://git-as-me/chriso…

0e8f66b

…wensboston/abstractit-puppet into add_puppetdb_manage_dbserver

calmenergy mentioned this pull request Apr 10, 2017

Added parameter puppet::profile::puppetdb_manage_dbserver #144

Merged

rendhalver closed this Apr 11, 2017

		in Gemfile, forced json_pure to be < 2.0.1 when ruby < 2.0 @chrisowensboston
		in .travis.yml, added a line for rvm 2.2.0, puppet gem 4.7.0, facter gem 2.4.6, hiera gem 3.2.1 @chrisowensboston

Conversation

chrisowensboston commented Nov 2, 2016

Uh oh!

rendhalver commented Nov 2, 2016

Uh oh!

chrisowensboston commented Nov 2, 2016

Uh oh!

rendhalver Nov 3, 2016

Choose a reason for hiding this comment

Uh oh!

chrisowensboston Nov 3, 2016

Choose a reason for hiding this comment

Uh oh!

rendhalver Nov 4, 2016

Choose a reason for hiding this comment

Uh oh!

rendhalver Nov 4, 2016

Choose a reason for hiding this comment

Uh oh!

chrisowensboston Nov 4, 2016

Choose a reason for hiding this comment

Uh oh!

rendhalver Nov 3, 2016

Choose a reason for hiding this comment

Uh oh!

chrisowensboston commented Nov 4, 2016

Uh oh!

rendhalver commented Nov 4, 2016

Uh oh!

chrisowensboston commented Feb 1, 2017

Uh oh!

rendhalver commented Apr 1, 2017

Uh oh!

chrisowensboston commented Apr 5, 2017 via email

Uh oh!

chrisowensboston commented Apr 7, 2017 via email

Uh oh!

rendhalver commented Apr 8, 2017

Uh oh!

rendhalver commented Apr 8, 2017

Uh oh!

rendhalver commented Apr 8, 2017

Uh oh!

rendhalver commented Apr 8, 2017

Uh oh!

chrisowensboston commented Apr 8, 2017 via email

Uh oh!

calmenergy commented Apr 10, 2017

Uh oh!

rendhalver commented Apr 10, 2017

Uh oh!

calmenergy commented Apr 10, 2017 via email

Uh oh!

rendhalver commented Apr 10, 2017

Uh oh!

calmenergy commented Apr 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants