Skip to content

sync#6286

Merged
neilpang merged 24 commits into
masterfrom
dev
Mar 28, 2025
Merged

sync#6286
neilpang merged 24 commits into
masterfrom
dev

Conversation

@neilpang

Copy link
Copy Markdown
Member

sync

fraenki and others added 24 commits November 7, 2022 23:43
Although the main use-case may be the --install command, this command
also proves to be useful for the --signcsr and --issue commands.
When acme.sh is run as a non-root user different from the owner of the
webroot directory it is unable to change the owner of the files in
.well-known to that user, causing permissions errors.  Avoid this by
making the files world-readable.

These files should pose no disclosure risk since they are sent in
cleartext during the HTTP Identifier Validation Challenge[1] and may
already be exposed by directory enumeration, depending on server
settings.  AFAIK they should be safe to expose as world-readable in all
cases.

1.  https://ietf-wg-acme.github.io/acme/#rfc.section.7.2

Fixes #32
Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
FreeBSD's sed requires an extension for the backup file when -i is used. However, it may be zero-length to indicate that no backup is desired.
Add FreeMyIP DNS Api Support
cqhttp notify-hook:Compatibility with QQ Headless Project Napcat
dns_he_ddns: Add empty dns_he_ddns_rm() to remove warnings
routeros: file-name should in quotes in newer (7.18) version
It was reported in issue #6267 that the private key was leaked when
using the DEPLOY_HAPROXY_HOT_UPDATE=yes feature.

Indeed, the debugging code which sends commands to HAProxy was using
_debug even when passing the private key.

This patch fixes the issue by using _secure_debug when doing that.
haproxy: don't leak private keys when doing --debug
update documentation for --cert-home parameter
Since the server in mainland China cannot connect to Telegram, add the TELEGRAM_BOT_URLBASE environment variable
Please add the proxy address you set. If this variable is not added, it will be the default value (https://api.telegram.org)
fix regex of matching hetzner dns api error responses
Avoid permissions errors for chown .well-known
@github-actions

Copy link
Copy Markdown

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@neilpang neilpang merged commit 73fdf4b into master Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.