Run post hook when _on_before_issue() errors#6445
Merged
neilpang merged 1 commit intoJul 13, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to
_on_before_issue()withinissue()runs the$_pre_hook, but when_on_before_issue()fails (e.g. standalone mode, port is already occupied), the$_post_hookis never called. This creates a disparity as there's no opportunity to clean up after a failure; if the pre hook makes a system change, the system is left in an inconsistent state.This PR adds the same post hook error handling, as per the rest of the
issue()function's calls happen.