ARI - Add support for switching ACME Server during renewal#6983
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ARI renewal handling in acme.sh so that when a CA rejects an order containing the RFC 9773 replaces field, the client retries newOrder without replaces—specifically targeting CAs that return ACME RFC8555/IANA error types like alreadyReplaced and malformed (per issue #6964).
Changes:
- Adjusted the retry trigger to look for exact ACME error type URNs (
...:alreadyReplaced,...:malformed) after a failednewOrderwithreplaces.
Critical Issues (Must Fix Before Merge)
- The new condition narrows behavior and no longer matches the nearby comment (“mentions ARI or the replaces field”), potentially regressing cases previously handled by the broader heuristics. (See PR comment.)
Suggestions (Improvements to Consider)
- None beyond the requested changes.
Good Practices (Points to Commend)
- None noted.
Comment on lines
+4894
to
+4898
| @@ -4895,7 +4895,7 @@ issue() { | |||
| # (Let's Encrypt) may also reject with a malformed error if the prior cert | |||
| # was issued by a different issuer / different CA. Retry without "replaces" | |||
| # whenever the failure mentions ARI or the replaces field. | |||
| if [ "$_replaces_certID" ] && { _contains "$response" "alreadyReplaced" || _contains "$response" "'replaces'" || _contains "$response" "ARI"; }; then | |||
| if [ "$_replaces_certID" ] && { _contains "$response" "urn:ietf:params:acme:error:alreadyReplaced" || _contains "$response" "urn:ietf:params:acme:error:malformed"; }; then | |||
Member
|
just add |
Contributor
Author
|
Done. I still think that it should be the same format:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #6964
Following the initial ACME RFC Section 9.7.4:
urn:ietf:params:acme:error:alreadyReplacedmalformedThis PR add support of exact Error Types
urn:ietf:params:acme:error:alreadyReplacedandurn:ietf:params:acme:error:malformed.