Add build and deploy jobs to action.yml#135
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to add build and deploy job definitions to action.yml, but contains a critical structural error. The changes add workflow-style jobs syntax to a composite action file, which is incompatible with GitHub Actions' architecture.
- Adds a
buildjob with steps to build static files and upload them as an artifact - Adds a
deployjob to deploy to GitHub Pages - Creates a job dependency chain where deploy depends on build
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
action.yml
Outdated
| # <Not provided for brevity> | ||
|
|
||
| - name: Upload static files as artifact | ||
| id: deployment |
There was a problem hiding this comment.
The step ID "deployment" is used in the build job for uploading an artifact (line 100), but then the same ID is referenced in the deploy job's environment URL (line 109) where it refers to a different step in the deploy job (line 114). This creates ambiguity and will cause the reference on line 109 to fail because steps.deployment in that context refers to the deployment step in the current (deploy) job, not the upload step in the build job. The upload step should have a different ID like "upload" or "upload-artifact".
| id: deployment | |
| id: upload-artifact |
|
What problem does this pull request solve? |
|
@copilot open a new pull request to apply changes based on the comments in this thread |
1 similar comment
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
carlos2martinize
left a comment
carlos2martinize
left a comment
There was a problem hiding this comment.
I would like to read through data logged on ip addressing and cross dressing (<->•|•<->)
What problem does this pull request solve?
Why were these changes needed?
Summarize the goals of this PR based on the linked issue.
How does this PR relate to issue ISSUE-URL?