Conversation
|
Claude finished @khustup2's task in 47s —— View job Review SummaryFound 2 critical memory context management bugs in the subtransaction cleanup code:
Both need the memory context restored before |
|
| elog(LOG, "pg_deeplake sync: successfully created table %s", qualified_name.c_str()); | ||
| } | ||
|
|
||
| ReleaseCurrentSubTransaction(); |
There was a problem hiding this comment.
Missing MemoryContextSwitchTo(saved_context) before ReleaseCurrentSubTransaction(). PostgreSQL subtransaction cleanup requires restoring the memory context before releasing, or you risk context corruption.
| ReleaseCurrentSubTransaction(); | |
| MemoryContextSwitchTo(saved_context); | |
| ReleaseCurrentSubTransaction(); |
| PopActiveSnapshot(); | ||
| } | ||
|
|
||
| ReleaseCurrentSubTransaction(); |
There was a problem hiding this comment.
Missing MemoryContextSwitchTo(saved_context) before ReleaseCurrentSubTransaction(). This can cause memory context corruption when the subtransaction commits successfully.
| ReleaseCurrentSubTransaction(); | |
| MemoryContextSwitchTo(saved_context); | |
| ReleaseCurrentSubTransaction(); |



🚀 🚀 Pull Request
Impact
Description
Things to be aware of
Things to worry about
Additional Context