Return error instead of panics on invalid ASN.1#9
Merged
acw merged 4 commits intoacw:masterfrom Mar 29, 2019
Merged
Conversation
Owner
|
This is awesome, and I'm always happy to add more (and more helpful) error variants. Let me check a couple things and then I'll merge it. |
Contributor
Author
|
Thanks! One thing I forgot to mention: The GeneralizedTime parser previously inserted the dot at position 15, 14 should be the right position :) |
Owner
|
Yes, I saw that and that was one of the things I wanted to look at (and maybe write a test case for). :) |
Owner
|
This version has been pushed as 0.4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I use this library to find out if something is ASN.1 or not, unfortunately it often panics on invalid input.
To find all panics I added a cargo-fuzz project and fixed all the panics it found.
With the final version, the fuzzer did not find any panic for half an hour.
Unfortunately this pr currently includes a breaking change because it adds error variants. So I’m not sure if you want to implement this someway else, e.g. return some of the existing errors instead.
Edit: I found this commit which also adds a
+ Errorbound to the error types.