Open
Conversation
Contributor
Author
|
oops - okay, documentation for the added things coming in a day or two.... |
| void ssd1306_commandList(const uint8_t *c, uint8_t n); | ||
|
|
||
| class Transaction; // forward declartion | ||
| friend class Transaction; |
Contributor
There was a problem hiding this comment.
This friendship has no effect. A member class already has private access to enclosing class.
Aside, I hope it is not necessary to have a comment explaining what a declaration is (line above).
mzero
force-pushed
the
transaction
branch
6 times, most recently
from
8b13a9a to
f739c8f
Compare
Contributor
Author
|
I have rebased this CL set to top of master... and fixed all the clang-format and doxygen issues. |
- this makes the code much more readable - and ensures that transactions are always properly framed - and makes multi-command transactions more efficient - and as if that weren't enough, makes the compiled library smaller!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of sending commands to the SSD1306 is factored out into a private
Transactionclass. This class gathers all the logic for handling sending multiple byte commands and data into one place.This has several advantages:
The second commit fleshes out the support for user code sending commands, so that multi-byte commands can be sent.
Addresses and fixes #164