Add Private Network Check#745
Closed
issackelly wants to merge 2 commits intoadamchainz:mainfrom
Closed
Conversation
issackelly
force-pushed
the
private-network
branch
from
666229b to
1ab5900
Compare
issackelly
force-pushed
the
private-network
branch
from
525303c to
7e033d7
Compare
for more information, see https://pre-commit.ci
Owner
|
Thanks for this. First time I've heard of this feature! After skimming the spec, it looks like one should only respond with |
Author
|
of course. thanks for the quick response. I will try to make this change shortly. |
|
@issackelly any chance you have some time to address @adamchainz feedback? 🙏 |
|
Hi, can this be merged soon? Thanks everyone. |
Owner
|
Superceded by #833, which has been merged with co-authored-by for you @issackelly . Thanks for your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google is starting to ship checks for Private Networks[1]. This is causing me to make some adjustments to my site and I figured I'd start down the path of a PR.
[1] https://developer.chrome.com/blog/private-network-access-preflight/