LeaveOpen wasn't respected by GZip#1346
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure IReaderOptions.LeaveStreamOpen is honored when constructing the internal GZip stream so callers can control whether the underlying stream is disposed.
Changes:
- Pass
readerOptions.LeaveStreamOpeninto theGZipStreaminitialization call.
Issue found (blocks approval):
- The new argument uses
readerOptions.LeaveStreamOpenbefore the existing null-guard (readerOptions ?? throw ...) used in the subsequent argument. IfreaderOptionsis ever null (which the guard implies is possible/expected), this now throwsNullReferenceExceptionearlier. The fix is to readLeaveStreamOpenfrom the same null-checked expression (or assign a local after the guard).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugfix from: #1282
This pull request makes a small change to the
GZipStreamclass to ensure that theLeaveStreamOpenoption fromreaderOptionsis passed when initializing the stream. This helps control whether the underlying stream remains open after theGZipStreamis disposed.