This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Upgrade ember 5#37
Merged
c0rydoras merged 12 commits intoadfinis:mainfrom Aug 2, 2023
Merged
Conversation
Closed
…it to updated models
…m string, which is deprecated
c0rydoras
force-pushed
the
upgrade-ember-5
branch
from
0ddab17 to
95066e6
Compare
anehx
suggested changes
Jul 11, 2023
Member
anehx
left a comment
anehx
left a comment
There was a problem hiding this comment.
Small nitpick in the eslint config, otherwise good job!
Member
|
LGTM, but your tests are failing. |
Collaborator
Author
|
@anehx The tests are failing due to mirage (miragejs/ember-cli-mirage#2444) |
c0rydoras
force-pushed
the
upgrade-ember-5
branch
from
155667e to
8fa3d74
Compare
anehx
approved these changes
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests will fail due to mirage not being compatible with ember-data 5 yet (miragejs/ember-cli-mirage#2444)
This PR includes
asyncandinverseon modelsnpx ember-cli-update --to 4.12)power-select,power-select-multiple) instead of usingensureSafeComponentwith their nameuseSessionSetupMethodtoember-cli-build.jsember-datato 4.12 which required some extra worknpx ember-cli-update --to 5.0