Skip to content

Enhance stuffs#4

Merged
adhocore merged 1 commit intoadhocore:masterfrom
peter279k:enhance_stuffs
Feb 27, 2019
Merged

Enhance stuffs#4
adhocore merged 1 commit intoadhocore:masterfrom
peter279k:enhance_stuffs

Conversation

@peter279k
Copy link
Copy Markdown
Contributor

Changed log

  • Add php-7.3 test on Travis CI build.
  • According to the PHPUnit Fixtures reference, the PHPUnit\Framework\TestCase::setUp should be protected, not public.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 27, 2019

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #4   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       70     70           
=======================================
  Files             2      2           
  Lines           143    143           
=======================================
  Hits            143    143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edad4a5...1f7fa21. Read the comment docs.

Copy link
Copy Markdown
Owner

@adhocore adhocore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@adhocore adhocore merged commit 6dd7613 into adhocore:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants