This repository was archived by the owner on Sep 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Remove "x" buttons from dialogs #166
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4921abc
#165 - Remove "x" buttons from dialogs
110ffde
Adding "Cancel" locale from Brackets project
06218c5
Adding Cancel button in browse dialog
c36dbcd
Move Cancel button to proper location, remove now unused CSS
ba6ef5a
Fixed incorrect button selector for Browse dialog
46da4c5
Remove unneeded lines
c2dbd0c
Version bump
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| <div class="edge-web-fonts-browse-dialog template modal hide"> | ||
| <div class="modal-header"> | ||
| <a href="#" class="close">×</a> | ||
| <h1 class="dialog-title">{{PRODUCT_NAME}}</h1> | ||
| </div> | ||
| <div class="modal-body"> | ||
| <div class="edge-web-fonts edge-web-fonts-browse-dialog-body"></div> | ||
| </div> | ||
| <div class="modal-footer"> | ||
| <span class="ewf-terms-of-use">{{{TERMS_OF_USE}}}</span> | ||
| <a href="#" class="dialog-button btn" data-button-id="cancel">{{CANCEL}}</a> | ||
| <a href="#" class="dialog-button btn primary" data-button-id="ok">{{DIALOG_DONE}}</a> | ||
| </div> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -223,7 +223,7 @@ define(function (require, exports, module) { | |
|
|
||
| function _showHowtoDialog() { | ||
| var dlg = Dialogs.showModalDialogUsingTemplate(ewfHowtoDialogTemplate); | ||
| dlg.getElement().find(".close").on("click", dlg.close.bind(dlg)); | ||
| dlg.getElement().find('.dialog-button[data-button-id="ok"]').on("click", dlg.close.bind(dlg)); | ||
|
|
||
| $(".edge-web-fonts-howto-diagram").css("background-image", "-webkit-image-set(url('" + howtoDiagramURL + "') 1x, url('" + howtoDiagramHiDPIURL + "') 2x)"); | ||
| } | ||
|
|
@@ -455,7 +455,7 @@ define(function (require, exports, module) { | |
| } | ||
| editor.focus(); | ||
| }); | ||
| dlg.getElement().find(".close").on("click", dlg.close.bind(dlg)); | ||
| dlg.getElement().find('.dialog-button[data-button-id="cancel"]').on("click", dlg.close.bind(dlg)); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry for just now realizing, but the Cancel button is already handled by default, so this is not necessary at all. This line of code should be removed. |
||
|
|
||
| webfont.renderPicker($('.edge-web-fonts-browse-dialog.instance')); | ||
|
|
||
|
|
@@ -498,7 +498,7 @@ define(function (require, exports, module) { | |
| } else { | ||
| includeString = webfont.createInclude(fontFamilies); | ||
| var dlg = Dialogs.showModalDialogUsingTemplate(ewfIncludeDialogTemplate); | ||
| dlg.getElement().find(".close").on("click", dlg.close.bind(dlg)); | ||
| dlg.getElement().find('.dialog-button[data-button-id="ok"]').on("click", dlg.close.bind(dlg)); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK button is already handled, so this is not necessary at all. This line of code should be removed. |
||
| $('.instance .ewf-include-string').html(StringUtils.htmlEscape(includeString)).focus().select(); | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK button is already handled, so this is not necessary at all. This line of code should be removed.