Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion htmlContent/ewf-browse-dialog.html
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<div class="edge-web-fonts-browse-dialog template modal hide">
<div class="modal-header">
<a href="#" class="close">&times;</a>
<h1 class="dialog-title">{{PRODUCT_NAME}}</h1>
</div>
<div class="modal-body">
<div class="edge-web-fonts edge-web-fonts-browse-dialog-body"></div>
</div>
<div class="modal-footer">
<span class="ewf-terms-of-use">{{{TERMS_OF_USE}}}</span>
<a href="#" class="dialog-button btn" data-button-id="cancel">{{CANCEL}}</a>
<a href="#" class="dialog-button btn primary" data-button-id="ok">{{DIALOG_DONE}}</a>
</div>
</div>
1 change: 0 additions & 1 deletion htmlContent/ewf-howto-dialog.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<div class="edge-web-fonts-howto-dialog template modal hide">
<div class="modal-header">
<a href="#" class="close">&times;</a>
<h1 class="dialog-title">{{Strings.PRODUCT_NAME}}</h1>
</div>
<div class="modal-body">
Expand Down
1 change: 0 additions & 1 deletion htmlContent/ewf-include-dialog.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<div class="edge-web-fonts-include-dialog template modal hide">
<div class="modal-header">
<a href="#" class="close">&times;</a>
<h1 class="dialog-title">{{PRODUCT_NAME}}</h1>
</div>
<div class="modal-body">
Expand Down
6 changes: 3 additions & 3 deletions main.js
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ define(function (require, exports, module) {

function _showHowtoDialog() {
var dlg = Dialogs.showModalDialogUsingTemplate(ewfHowtoDialogTemplate);
dlg.getElement().find(".close").on("click", dlg.close.bind(dlg));
dlg.getElement().find('.dialog-button[data-button-id="ok"]').on("click", dlg.close.bind(dlg));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK button is already handled, so this is not necessary at all. This line of code should be removed.


$(".edge-web-fonts-howto-diagram").css("background-image", "-webkit-image-set(url('" + howtoDiagramURL + "') 1x, url('" + howtoDiagramHiDPIURL + "') 2x)");
}
Expand Down Expand Up @@ -455,7 +455,7 @@ define(function (require, exports, module) {
}
editor.focus();
});
dlg.getElement().find(".close").on("click", dlg.close.bind(dlg));
dlg.getElement().find('.dialog-button[data-button-id="cancel"]').on("click", dlg.close.bind(dlg));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for just now realizing, but the Cancel button is already handled by default, so this is not necessary at all. This line of code should be removed.


webfont.renderPicker($('.edge-web-fonts-browse-dialog.instance'));

Expand Down Expand Up @@ -498,7 +498,7 @@ define(function (require, exports, module) {
} else {
includeString = webfont.createInclude(fontFamilies);
var dlg = Dialogs.showModalDialogUsingTemplate(ewfIncludeDialogTemplate);
dlg.getElement().find(".close").on("click", dlg.close.bind(dlg));
dlg.getElement().find('.dialog-button[data-button-id="ok"]').on("click", dlg.close.bind(dlg));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK button is already handled, so this is not necessary at all. This line of code should be removed.

$('.instance .ewf-include-string').html(StringUtils.htmlEscape(includeString)).focus().select();
}
}
Expand Down
1 change: 1 addition & 0 deletions nls/de/strings.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ define({
"PRODUCT_NAME" : "Adobe Edge Web Fonts",

"DIALOG_DONE" : "Fertig",
"CANCEL" : "Abbrechen",
"SEARCH_PLACEHOLDER" : "Suchen",
"BROWSE_FONTS_INSTRUCTIONS" : "Suchen und wählen Sie die Schrift, die Sie in ihrem Webprojekt integrieren möchten.",
"CODEHINT_BROWSE" : "Web-Fonts durchsuchen...", // Needs to be short to fit in popup, but not sure about acronym
Expand Down
1 change: 1 addition & 0 deletions nls/fr/strings.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ define({
"PRODUCT_NAME": "Edge Web Fonts",

"DIALOG_DONE": "Terminé",
"CANCEL": "Annuler",
"SEARCH_PLACEHOLDER": "Rechercher",
"BROWSE_FONTS_INSTRUCTIONS": "Recherchez et sélectionnez la police Web que vous souhaitez inclure dans votre projet Web.",
"CODEHINT_BROWSE": "Parcourir les polices Web...",
Expand Down
1 change: 1 addition & 0 deletions nls/ja/strings.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ define({
"PRODUCT_NAME": "Edge Web Fonts",

"DIALOG_DONE": "完了",
"CANCEL": "キャンセル",
"SEARCH_PLACEHOLDER": "検索",
"BROWSE_FONTS_INSTRUCTIONS": "Web プロジェクトに追加する Web フォントを探して選択してください。",
"CODEHINT_BROWSE": "Web Fonts を検索...",
Expand Down
1 change: 1 addition & 0 deletions nls/root/strings.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ define({
"PRODUCT_NAME" : "Edge Web Fonts",

"DIALOG_DONE" : "Done",
"CANCEL" : "Cancel",
"SEARCH_PLACEHOLDER" : "Search",
"BROWSE_FONTS_INSTRUCTIONS" : "Browse for and select the web font you wish to include in your web project.",
"CODEHINT_BROWSE" : "Browse Web Fonts...", // Needs to be short to fit in popup, but not sure about acronym
Expand Down
7 changes: 0 additions & 7 deletions styles/ewf-brackets.css
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,6 @@
*
*/

.edge-web-fonts-browse-dialog .modal-header .close,
.edge-web-fonts-include-dialog .modal-header .close,
.edge-web-fonts-howto-dialog .modal-header .close {
margin-top: 0px;
line-height: 40px;
}

.edge-web-fonts-browse-dialog .modal-body {
width: 520px;
padding: 15px 0 15px 15px;
Expand Down