This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Forcefully disabling renderer accesibility#660
Merged
vickramdhawal merged 4 commits intomasterfrom Oct 16, 2018
Merged
Conversation
…ormance issues with Windows update KB4343909
Contributor
Author
|
Fixes adobe/brackets#14515 |
…ter the user has passed on --force-renderer-accessibility or --enable-renderer-accessibility
swmitra
approved these changes
Oct 15, 2018
Collaborator
swmitra
left a comment
swmitra
left a comment
There was a problem hiding this comment.
LGTM as you have already addressed selectively applying the flag. I will leave to the other reviewers now.
vickramdhawal
suggested changes
Oct 15, 2018
vickramdhawal
approved these changes
Oct 16, 2018
nethip
added a commit
that referenced
this pull request
Oct 16, 2018
* Forcefully disabling renderer accesibility as this is leading to performance issues with Windows update KB4343909 * Conditionally adding disable-renderer-accessibility flag based on wheter the user has passed on --force-renderer-accessibility or --enable-renderer-accessibility * Code cleanup and fixed documentation. * Restricting the accessibility option only to Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows update KB4343909 is leading to performance issues on some systems. This is because of accessiblity renderer tree getting created wrongly. So disabling this for now.
Thanks to @katoken-0215 for pointing this out.
@abhijitapte @swmitra Could you please review this?