Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Sprint 31 draft#66

Merged
jasonsanjose merged 3 commits intomasterfrom
randy/sprint31-draft
Sep 13, 2013
Merged

Sprint 31 draft#66
jasonsanjose merged 3 commits intomasterfrom
randy/sprint31-draft

Conversation

@redmunds
Copy link
Copy Markdown
Contributor

I basically copy/pasted from Release Notes draft.

@jasonsanjose @njx @adrocknaphobia

Comment thread updates/stable/en.json Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user facing feature from the related pull request is actually an Arch Linux distribution of Brackets. It likely won't land, but if it does, lets translate this:

Arch Linux Support
Brackets is now available for Arch Linux on the Arch User Repository (AUR).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jasonsanjose
Copy link
Copy Markdown
Member

Initial review complete

Comment thread updates/stable/en.json Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should make this more specific ("HTML Tag Highlighting")?

@redmunds
Copy link
Copy Markdown
Contributor Author

@jasonsanjose Pushed changes for your comments.
@njx Let me know when you're done reviewing.

Comment thread updates/stable/en.json Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've normally used title casing for these names, e.g. Keyboard Support for Recent Projects. Should fix the CSS update too.

@jasonsanjose
Copy link
Copy Markdown
Member

Changes look good. Just the one last comment.

@njx
Copy link
Copy Markdown

njx commented Sep 13, 2013

I think you missed my comment about the "HTML Editing" heading (it should be more specific, like "HTML Matching Tag Highlighting" or some such). Otherwise it looks fine.

@redmunds
Copy link
Copy Markdown
Contributor Author

Pushed changes based on second round of comments. Ready for re-review.

@jasonsanjose
Copy link
Copy Markdown
Member

Merging.

jasonsanjose added a commit that referenced this pull request Sep 13, 2013
@jasonsanjose jasonsanjose merged commit c47ec74 into master Sep 13, 2013
@jasonsanjose jasonsanjose deleted the randy/sprint31-draft branch September 13, 2013 22:22
@peterflynn
Copy link
Copy Markdown
Member

@jasonsanjose Could we preemptively add a blurb for PR #5191, in case we find cycles to merge it? It would definitely be notification-worthy if it got in. (And easy to yank from the update text if it doesn't).

@redmunds
Copy link
Copy Markdown
Contributor Author

@peterflynn Can you add the blurb? If you can't access the file, post the description here and I'll put it in. I already sent an e-mail to the LOC team to localize the updates, so this needs to get it in ASAP.

@peterflynn
Copy link
Copy Markdown
Member

@redmunds How about:

            {
                "name": "Search Result Tickmarks",
                "description": "Find results are visually mapped out as yellow tickmarks along the scroll bar track."
            },

@redmunds
Copy link
Copy Markdown
Contributor Author

Done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants