This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Handle 'platforms' from new updates.json entry#222
Merged
narayani28 merged 2 commits intogh-pagesfrom Apr 6, 2020
Merged
Conversation
narayani28
reviewed
Oct 26, 2018
| break; | ||
| } else { | ||
| if (OS === "OTHER") { // Unsupported platform detected | ||
| if (Object.keys(build.platforms).length == 4) { |
Contributor
There was a problem hiding this comment.
shouldn't this be === . Also what does this check mean?
Collaborator
Author
There was a problem hiding this comment.
We are avoiding a type check as both the LHS and RHS are know to be numbers.
Contributor
There was a problem hiding this comment.
shouldn't (build.platforms[OS]) be the first check ? Also, how does checking for length of keys the build.platforms help ? what if support for another platform is added in future ?
vickramdhawal
suggested changes
Oct 29, 2018
| break; | ||
| } else { | ||
| if (OS === "OTHER") { // Unsupported platform detected | ||
| if (Object.keys(build.platforms).length == 4) { |
Contributor
There was a problem hiding this comment.
shouldn't (build.platforms[OS]) be the first check ? Also, how does checking for length of keys the build.platforms help ? what if support for another platform is added in future ?
vickramdhawal
approved these changes
Nov 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle platform entries from updates.json. This PR adds capability to identify OS specific releases and offer download accordingly. In new update entry format, every platform node provides a dedicated
downloadURL. This PR makes use of thatdownloadURLwhen present instead of generating the installer asset URI.This is how the new Update entries look like -
{ "buildNumber": 17696, "versionString": "Release 1.13", "dateString": "06-18-2018", "releaseNotesURL": "https://github.com/adobe/brackets/wiki/Release-Notes:-1.13", "downloadURL": "http://brackets.io", "newFeatures": [ { "name": "Organize Files/Folders in File Tree", "description": "You can now manipulate folder structure from within Brackets. Move a file/folder from one folder to another with a simple drag and drop." }, { "name": "Open Remote Files", "description": "You can now open a remotely hosted web-page from within Brackets. Use Ctrl/Cmd-Shift-O shortcut and supply a URL to quickly open the file and review the code within Brackets." }, { "name": "Auto-Update", "description": "You can now automatically update Brackets, without leaving the code editor. " } ], "platforms" : { "WIN": { "checksum": "a1020f55d4ec92c824ed6e5a3db941eaae6ffeb2334a77fa3465fe2736304a86", "downloadURL": "https://github.com/adobe/brackets/releases/download/release-1.13/Brackets.Release.1.13.msi" }, "OSX": { "checksum": "34d8960d78e7301febcc6b68b85970d119b7a904cdb9a0ecfc445348de1e4bd4", "downloadURL": "https://github.com/adobe/brackets/releases/download/release-1.13/Brackets.Release.1.13.dmg" }, "LINUX32" : { "checksum": "3a83332e4e54fa3721dfa7e67a9d143c0b2658aec9de9b0c1042435f5f496624", "downloadURL" : "https://github.com/adobe/brackets/releases/download/release-1.13/Brackets.Release.1.13.32-bit.deb" }, "LINUX64" : { "checksum" : "5c489a51d14b66d696f1b167018dae598f9a27c1bd08a4026334e300f7dc93cf", "downloadURL" : "https://github.com/adobe/brackets/releases/download/release-1.13/Brackets.Release.1.13.64-bit.deb" } }, "prerelease" : "false" }@nethip @vickramdhawal Please review.