Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 59587ec

Browse files
committed
Add check for no "functions" returned (as requested by code review).
1 parent 8fbbeed commit 59587ec

1 file changed

Lines changed: 11 additions & 5 deletions

File tree

  • src/extensions/default/JavaScriptQuickEdit

src/extensions/default/JavaScriptQuickEdit/main.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,17 @@ define(function (require, exports, module) {
125125
fileInfos.push({name: jumpResp.resultFile, fullPath: resolvedPath});
126126
JSUtils.findMatchingFunctions(functionName, fileInfos)
127127
.done(function (functions) {
128-
var jsInlineEditor = new MultiRangeInlineEditor(functions);
129-
jsInlineEditor.load(hostEditor);
130-
131-
PerfUtils.addMeasurement(PerfUtils.JAVASCRIPT_INLINE_CREATE);
132-
result.resolve(jsInlineEditor);
128+
if (functions && functions.length > 0) {
129+
var jsInlineEditor = new MultiRangeInlineEditor(functions);
130+
jsInlineEditor.load(hostEditor);
131+
132+
PerfUtils.addMeasurement(PerfUtils.JAVASCRIPT_INLINE_CREATE);
133+
result.resolve(jsInlineEditor);
134+
} else {
135+
// No matching functions were found
136+
PerfUtils.addMeasurement(PerfUtils.JAVASCRIPT_INLINE_CREATE);
137+
result.reject();
138+
}
133139
})
134140
.fail(function () {
135141
PerfUtils.addMeasurement(PerfUtils.JAVASCRIPT_INLINE_CREATE);

0 commit comments

Comments
 (0)